Add Tests/RoundoffDomain #3248
Merged
Add Tests/RoundoffDomain #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
test_roundoff_domain
branch
5 times, most recently
from
bece8ef
to
afa2067
Compare
The new test exposes an issue with Intel compiler. So we have to rewrite the computeRoundoffDomain slightly. Also fix an assertion issue in AMReX-Codes#3247.
WeiqunZhang
force-pushed
the
test_roundoff_domain
branch
from
afa2067
to
a5fbb6d
Compare
This was referenced Apr 11, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
The new test exposes an issue with Intel compiler. So we have to rewrite the computeRoundofDomain function in a slightly different way to avoid roundoff difference between `auto r = f(x-y)` and `z = x-y; auto r = f(z)`. Also fix an assertion issue in AMReX-Codes#3247.
WeiqunZhang
pushed a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 28, 2023
* Rework handling of roundoff domain extent (AMReX-Codes#3199) * Fix periodic boundary bug in AMReX-Codes#3199 (AMReX-Codes#3243) * Fix Roundoff Domain (AMReX-Codes#3247) * Add Tests/RoundoffDomain (AMReX-Codes#3248) * Roundoff errors in computeRoundoffDomain (AMReX-Codes#3255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test exposes an issue with Intel compiler. So we have to rewrite the computeRoundofDomain function in a slightly different way to avoid roundoff difference between
auto r = f(x-y)andz = x-y; auto r = f(z).Also fix an assertion issue in #3247.