-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTD fields with RZ + openPMD - single mode only #3350
Merged
ax3l
merged 11 commits into
ECP-WarpX:development
from
RevathiJambunathan:BTD_RZ_fields
Oct 31, 2022
Merged
BTD fields with RZ + openPMD - single mode only #3350
ax3l
merged 11 commits into
ECP-WarpX:development
from
RevathiJambunathan:BTD_RZ_fields
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
component: diagnostics
all types of outputs
geometry: RZ
axisymmetric 2D and quasi-3D
component: boosted frame
boosted frame components & logic
labels
Oct 2, 2022
RevathiJambunathan
force-pushed
the
BTD_RZ_fields
branch
from
October 24, 2022 18:44
741bc3e
to
570d55f
Compare
…date hi ki-index after flush
…rate PArticle and Field io further. Also, clean up Particle Buffer initialize so its consistent with Field box, boxarray, dmap, and geom
RevathiJambunathan
force-pushed
the
BTD_RZ_fields
branch
from
October 25, 2022 20:42
37291cf
to
aa55c84
Compare
for more information, see https://pre-commit.ci
ax3l
reviewed
Oct 26, 2022
RevathiJambunathan
changed the title
BTD fields with RZ + openPMD
BTD fields with RZ + openPMD - single mode only
Oct 28, 2022
From Axels' review Co-authored-by: Axel Huebl <[email protected]>
1 task
ax3l
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 22, 2022
* cell center BTD functors for RZ with openpmd * add RZ modes to output varnames too * update varnames once and set map for RZ fields in BTfunctor * fix access to varname field instead of unallocated m_varnames, and update hi ki-index after flush * set back trasnformed fields to false if fields_to_plot is none. Separate PArticle and Field io further. Also, clean up Particle Buffer initialize so its consistent with Field box, boxarray, dmap, and geom * clean commented line * assert for single rz mode * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused var * Apply suggestions from code review From Axels' review Co-authored-by: Axel Huebl <[email protected]> * adding comments, doxygen, and clean-up Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: boosted frame
boosted frame components & logic
component: diagnostics
all types of outputs
enhancement
New feature or request
geometry: RZ
axisymmetric 2D and quasi-3D
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the file in Issue #3389 to ensure only one rz mode.
inputs_issue3389.txt
Attached is the modified input file
You can change
fields_to_plot = none
to use Er, Et, Ez , B, j, rhoThis runs fine on summit. I am yet to visualize it