Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

認証smtpメールが送れない問題 #558

Merged
merged 25 commits into from
Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
35ea2bf
LC_Page_Admin_*_Ex のクラスパスが正常に取得できないのを修正
nanasess May 6, 2022
884bab7
認証smtpメールが送れない問題
nobuhiko Jun 13, 2022
1086200
testが落ちる件
nobuhiko Jun 13, 2022
1705f85
Update dependabot.yml
nobuhiko Jul 27, 2022
10f38a5
fix: upgrade webpack from 5.69.1 to 5.73.0
snyk-bot Jul 27, 2022
c7cd2ec
fix: upgrade css-loader from 6.6.0 to 6.7.1
snyk-bot Jul 27, 2022
fbcd9a1
fix: upgrade jquery-migrate from 3.3.2 to 3.4.0
snyk-bot Jul 27, 2022
732828b
Merge pull request #1 from nobuhiko/snyk-upgrade-0d84ad8f89f22eac9b3f…
nobuhiko Jul 27, 2022
3abd057
Merge pull request #2 from nobuhiko/snyk-upgrade-f589dfd21dd238a91520…
nobuhiko Jul 27, 2022
d555236
Merge pull request #3 from nobuhiko/snyk-upgrade-3c3583d19e979a3e5fa5…
nobuhiko Jul 27, 2022
c494b29
guzzleかmailcatcherの返り値が変わったぽい
nobuhiko Jul 28, 2022
d64ecc6
Fix phpstan
nanasess Jul 29, 2022
70fc750
PHPStan が MDB2 を見つけてくれないのを修正
nanasess Jul 29, 2022
5969d75
guzzlehttp/guzzleを削除
nobuhiko Jul 29, 2022
30bb157
削除漏れ
nobuhiko Jul 29, 2022
45923ef
LC_Page_Admin_(Home|Index|Logout)_Ex に対応
nanasess Aug 1, 2022
03664ad
*_Ex クラスを追加した場合の E2E テストを追加
nanasess Aug 1, 2022
8c01e8c
Merge pull request #560 from EC-CUBE/nobuhiko-patch-3
chihiro-adachi Aug 3, 2022
056cadc
Merge pull request #561 from nobuhiko/snyk-upgrade
chihiro-adachi Aug 3, 2022
51bab13
Merge pull request #562 from nobuhiko/fix_mailcatcher
chihiro-adachi Aug 3, 2022
1a24dff
Merge pull request #563 from nanasess/fix-phpstan
chihiro-adachi Aug 3, 2022
c8b4836
Merge pull request #553 from nanasess/fix-admin-autoloader
chihiro-adachi Aug 3, 2022
ff03320
認証smtpメールが送れない問題
nobuhiko Jun 13, 2022
43dfb92
testが落ちる件
nobuhiko Jun 13, 2022
681f909
Merge branch 'smtp' of github.com:nobuhiko/ec-cube2 into smtp
nobuhiko Aug 3, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,15 @@ updates:
interval: "weekly"
allow:
- dependency-type: "all"

# GitHub アクションの依存関係を維持する
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"

# npm の依存関係を維持する
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"
9 changes: 8 additions & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
strategy:
fail-fast: false
matrix:
pattern:
- 'test:e2e'
- 'test:e2e-extends'
group:
- 'test/front_login'
- 'test/front_guest'
Expand All @@ -35,6 +38,9 @@ jobs:
- name: Setup environment
run: echo "COMPOSE_FILE=docker-compose.yml:docker-compose.pgsql.yml:docker-compose.dev.yml:docker-compose.owaspzap.yml:docker-compose.owaspzap.daemon.yml" >> $GITHUB_ENV

- if: matrix.pattern == 'test:e2e-extends'
run: cp -rp tests/class/fixtures/page_extends/* data/class_extends/page_extends

- name: Setup to EC-CUBE
env:
HTTP_URL: https://127.0.0.1:8085/
Expand All @@ -58,11 +64,12 @@ jobs:
- name: Run to E2E testing
env:
GROUP: ${{ matrix.group }}
PATTERN: ${{ matrix.pattern }}
HTTPS_PROXY: 'localhost:8090'
HTTP_PROXY: 'localhost:8090'
CI: 1
FORCE_COLOR: 1
run: yarn test:e2e e2e-tests/${GROUP}
run: yarn ${PATTERN} e2e-tests/${GROUP}

- name: Upload evidence
if: failure()
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
},
"require-dev": {
"fzaninotto/faker": "^1.8",
"guzzlehttp/guzzle": "^5.3",
"nanasess/eccube2-fixture-generator": "^1.1",
"nanasess/ec-cube2-class-extends-stubs": "^1.0",
"php5friends/phpunit48": ">=4.8.41"
Expand Down
248 changes: 2 additions & 246 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion data/class/SC_ClassAutoloader.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ public static function autoload($class, $plugin_upload_realdir = PLUGIN_UPLOAD_R
$arrClassNamePartTemp = $arrClassNamePart;
// FIXME クラスファイルのディレクトリ命名が変。変な現状に合わせて強引な処理をしてる。
$arrClassNamePartTemp[1] = $arrClassNamePartTemp[1] . '_extends';
$classpath .= strtolower(implode('/', array_slice($arrClassNamePartTemp, 1, -2))) . '/';
if ($count <= 5 && $arrClassNamePart[2] === 'Admin' && !in_array($arrClassNamePart[3], ['Home', 'Index', 'Logout'])) {
$classpath .= strtolower(implode('/', array_slice($arrClassNamePartTemp, 1, -1))) . '/';
} else {
$classpath .= strtolower(implode('/', array_slice($arrClassNamePartTemp, 1, -2))) . '/';
}
} elseif ($arrClassNamePart[0] === 'SC' && $is_ex === false && $count >= 3) {
$classpath .= strtolower(implode('/', array_slice($arrClassNamePart, 1, -1))) . '/';
} elseif ($arrClassNamePart[0] === 'SC') {
Expand Down
1 change: 1 addition & 0 deletions data/class/SC_SendMail.php
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ public function sendMail($isHtml = false)
$msg = mb_convert_encoding($result->getMessage(), CHAR_CODE, 'auto');
$msg = 'メール送信に失敗しました。[' . $msg . ']';
trigger_error($msg, E_USER_WARNING);
GC_Utils_Ex::gfPrintLog($result->getMessage());
GC_Utils_Ex::gfDebugLog($header);

return false;
Expand Down
1 change: 1 addition & 0 deletions data/module/Net/Socket.php
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ function enableCrypto($enabled, $type)
if (!is_resource($this->fp)) {
return $this->raiseError('not connected');
}
stream_context_set_option($this->fp, 'ssl', 'verify_peer_name', false);
return @stream_socket_enable_crypto($this->fp, $enabled, $type);
} else {
$msg = 'Net_Socket::enableCrypto() requires php version >= 5.1.0';
Expand Down
12 changes: 1 addition & 11 deletions data/module/Net/URL.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,6 @@ class Net_URL
*/
var $useBrackets;

/**
* PHP4 Constructor
*
* @see __construct()
*/
function Net_URL($url = null, $useBrackets = true)
{
$this->__construct($url, $useBrackets);
}

/**
* PHP5 Constructor
*
Expand All @@ -127,7 +117,7 @@ function Net_URL($url = null, $useBrackets = true)
* multiple querystrings with the same name
* exist
*/
function __construct($url = null, $useBrackets = true)
public function __construct($url = null, $useBrackets = true)
{
$this->url = $url;
$this->useBrackets = $useBrackets;
Expand Down
Loading