Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

認証smtpメールが送れない問題 #558

Merged
merged 25 commits into from
Sep 7, 2022

Conversation

nobuhiko
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #558 (681f909) into master (4ee4912) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   54.63%   54.61%   -0.02%     
==========================================
  Files          76       76              
  Lines        9058     9061       +3     
==========================================
  Hits         4949     4949              
- Misses       4109     4112       +3     
Flag Coverage Δ
tests 54.61% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_SendMail.php 86.23% <0.00%> (-0.63%) ⬇️
data/class/SC_ClassAutoloader.php 80.64% <100.00%> (+0.64%) ⬆️
data/class/SC_Query.php 67.90% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nobuhiko and others added 23 commits June 13, 2022 18:12
Snyk has created this PR to upgrade webpack from 5.69.1 to 5.73.0.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/nobuhiko/project/f6260ae3-109d-4dfe-aaaa-873ab966ddfb?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade css-loader from 6.6.0 to 6.7.1.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/nobuhiko/project/f6260ae3-109d-4dfe-aaaa-873ab966ddfb?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade jquery-migrate from 3.3.2 to 3.4.0.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/nobuhiko/project/f6260ae3-109d-4dfe-aaaa-873ab966ddfb?utm_source=github&utm_medium=referral&page=upgrade-pr
…03b27b7fcfe7

[Snyk] Upgrade webpack from 5.69.1 to 5.73.0
…5e28f49fe53e

[Snyk] Upgrade css-loader from 6.6.0 to 6.7.1
…b2dafcd89c6c

[Snyk] Upgrade jquery-migrate from 3.3.2 to 3.4.0
> Class Net_URL does not have a constructor and must be instantiated without any parameters.
テストが落ちる問題の修正
LC_Page_Admin_*_Ex のクラスパスが正常に取得できないのを修正
@nanasess
Copy link
Contributor

nanasess commented Aug 4, 2022

従来は STARTTLS に対応しておらず、 sendgrid など STARTTLS が強制される SMTP サーバーを利用する場合は以下のように SMTPS を使用する必要がありました。

define('SMTP_HOST', 'ssl://<smtp-server-host>');
define('SMTP_PORT', '465');
define('SMTP_USER', '<smtp user>');
define('SMTP_PASSWORD', '<smtp password>');

本PRで STARTTLS でも通信できるようになりましたので、 ポート587でも使用可能になりました。

define('SMTP_HOST', '<smtp-server-host>');
define('SMTP_PORT', '587');
define('SMTP_USER', '<smtp user>');
define('SMTP_PASSWORD', '<smtp password>');

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Sep 7, 2022
@chihiro-adachi chihiro-adachi merged commit 68a3a29 into EC-CUBE:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants