-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change workflow to mamba #429
Conversation
@chengzhuzhang Once this pull request and #428 merged, I can probably create equivalent pull requests for both @tomvothecoder I believe in our meeting, we discussed that the only necessary change was to remove the
I added a change to use |
@forsyth2, my comment was referring to this yaml file: Here, you will want to install all the packages currently being installed with pip using |
.github/workflows/build_workflow.yml
Outdated
@@ -118,7 +118,8 @@ jobs: | |||
- name: Install Dependencies | |||
run: | | |||
python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -m pip install --upgrade pip | |
mamba install -y sphinx==5.2.3 sphinx_rtd_theme==1.0.0 sphinx-multiversion==0.2.4 docutils==0.16 |
.github/workflows/build_workflow.yml
Outdated
pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 docutils==0.16 | ||
mamba install sphinx-multiversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 docutils==0.16 | |
mamba install sphinx-multiversion |
@@ -38,7 +38,8 @@ jobs: | |||
- name: Install Dependencies | |||
run: | | |||
python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -m pip install --upgrade pip |
pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 docutils==0.16 | ||
mamba install sphinx-multiversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install sphinx==5.2.3 sphinx_rtd_theme==1.0.0 docutils==0.16 | |
mamba install sphinx-multiversion | |
mamba install -y sphinx==5.2.3 sphinx_rtd_theme==1.0.0 sphinx-multiversion==0.2.4 docutils==0.16 |
@forsyth2, here is how I am using mambaforge instead of miniconda in my GitHub Actions: I'd suggest doing that here, too. |
@tomvothecoder @xylar I think this pull request should be good to go. Please let me know if I'm missing anything. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forsyth2, sorry for the delay. I didn't realize this was waiting on me. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Change workflow to mamba
* Change workflow to mamba (#429) * Change workflow to mamba * Fix GitHub Actions (#434) * Fix GitHub Actions * Revert sphinx-multiversion handling * Get sphinx-multiversion from conda-forge * Remove redundant dependency installation * Switch docs workflows to mamba --------- Co-authored-by: forsyth2 <[email protected]>
Change workflow to mamba. Resolves #397.