Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docs to mamba and Mambaforge #428

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

xylar
Copy link
Contributor

@xylar xylar commented May 22, 2023

Addresses #427


Or you can install ``zppy`` in an existing environment. ::
mamba create -n zppy_env zppy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Thanks for putting this together. I'm following along with the instructions but at this command I get bash: mamba: command not found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you install Mambaforge? If not, did you got to the Troubleshooting section below?

@xylar
Copy link
Contributor Author

xylar commented May 23, 2023

@forsyth2, if my troubleshooting section isn't intuitive, feel free to reorganize (either by suggesting changes or pushing to my branch). You could move that stuff back as (hopefully) redundant parts of the basic installation.

@xylar
Copy link
Contributor Author

xylar commented May 23, 2023

I've gone ahead and reorganized in a way that I hope is more intuitive for you.

Copy link
Collaborator

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xylar. Following these instructions, I was able to set up both the production environment and the development environment. I still need to make the changes mentioned in #397 however.

@xylar
Copy link
Contributor Author

xylar commented May 24, 2023

@forsyth2, I see, I had forgotten how the issues were interrelated. You are right that the yaml file should also be updated to switch sphinx-multiversion to come from conda-forge, not pip. That seems like a trivial change.

I think everything else in #397 relates to GitHub Actions (which is installing a lot of stuff from pip). I didn't see anywhere else that pip was being used in zppy (besides pip install ., which is fine). So I think other than maybe the one sphinx-multiversion change, #397 is not related to this change, which is about how developers interact with zppy, rather than what CI does.

@forsyth2
Copy link
Collaborator

@xylar Is this ready to merge?

@xylar
Copy link
Contributor Author

xylar commented Jun 14, 2023

@forsyth2, yes, as far as I'm concerned, this is ready to merge.

@forsyth2 forsyth2 merged commit 8d0aa9d into E3SM-Project:main Jun 14, 2023
@forsyth2 forsyth2 deleted the switch-docs-to-mamba-mambaforge branch June 14, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants