Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate MALI thermal solver and update configuration to be relevant to both AIS and GIS grids #6559

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

matthewhoffman
Copy link
Contributor

@matthewhoffman matthewhoffman commented Aug 21, 2024

This PR updates a number of details about the MALI configuration to support both Antarctica and Greenland Ice Sheet configurations:

  • Enables the MALI thermal solver, which is needed to allow evolving calving fronts, in preparation for enabling calving
  • Adds new logic to make the albany_input.yaml file specific to a mesh. This is needed because AIS and GIS meshes use different solver boundary conditions that are specified in that file.
  • Enables config_remove_icebergs and config_remove_small_islands, two options that improve convergence of the velocity solver and are typically used in standalone MALI simulations
  • Adds additional fields to the MALI history files related to the now activated thermal solver, as well as ice-shelf basal melting. Also updates the MALI globalStats files to write out all global stats instead of the subset that was hardcoded before.
  • Updates the ERS_Ld5.TL319_oQU240wLI_ais20.MPAS_LISIO_JRA1p5.mpaso-ocn_glcshelf test to the MALI ais8to30 grid that was recently added. When the mesh was added, the test was failing due to issues with the thermal solver, but those have been resolved between MALI thermal solver bug fix and improved iceberg handling #6547 and this PR, so we can now update that test to the newer mesh.

[NML] for all configurations with MALI
[non-BFB] for all configurations with active MALI

Enable iceberg and small island checkers for stability.
Enable thermal solver to allow ice-sheet extent to evolve without
issues.
@matthewhoffman matthewhoffman added mpas-ocean mpas-albany-landice BFB PR leaves answers BFB Testing Anything related to unit/system tests labels Aug 21, 2024
Also create the corresponding albany_input.*.yaml files
This was not possible when the mesh was added due to issues with the
treatment of temperature in MALI.  Now that those issues have been
resolved, this test can be updated to the newer mesh.
@matthewhoffman matthewhoffman force-pushed the matthewhoffman/mali/enable_thermal_solver branch from 777b747 to 57c057e Compare August 21, 2024 19:58
@matthewhoffman
Copy link
Contributor Author

@stephenprice , here is the branch we were talking about that enables the thermal solver that you can test out with your various Greenland configurations.

@trhille , @stephenprice , @mperego , look over the changes to the namelist defaults and the new fields added to the history files and let me know if there is anything else you think we should include.

@mperego and @jonbob , let me know if you are happy with the way I've implemented supporting mesh-specific albany_input.yaml files.

@jonbob , I've only tested the test that is updated as part of this PR, so I will need help finding and running all the tests that use MALI.

Copy link

github-actions bot commented Aug 21, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6559/
on branch gh-pages at 2024-08-27 22:48 UTC

@rljacob rljacob removed the request for review from jonbob August 21, 2024 20:35
Copy link
Contributor

@mperego mperego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
I left a comment about having CPU and GPU versions of Albany input files, but it does not need to be addressed in this PR.

Copy link
Contributor

@stephenprice stephenprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor suggestions / questions here Matt. I am happy to approve now regardless of what we decide to do in response to those.

@jonbob jonbob added NML and removed mpas-ocean labels Sep 4, 2024
jonbob added a commit that referenced this pull request Sep 5, 2024
…#6559)

Activate MALI thermal solver and update configuration to be relevant to both AIS and GIS grids

This PR updates a number of details about the MALI configuration to
support both Antarctica and Greenland Ice Sheet configurations:
* Enables the MALI thermal solver, which is needed to allow evolving
  calving fronts, in preparation for enabling calving
* Adds new logic to make the albany_input.yaml file specific to a mesh.
  This is needed because AIS and GIS meshes use different solver
  boundary conditions that are specified in that file.
* Enables config_remove_icebergs and config_remove_small_islands, two
  options that improve convergence of the velocity solver and are
  typically used in standalone MALI simulations
* Adds additional fields to the MALI history files related to the now
  activated thermal solver, as well as ice-shelf basal melting. Also
  updates the MALI globalStats files to write out all global stats
  instead of the subset that was hardcoded before.
* Updates the
    ERS_Ld5.TL319_oQU240wLI_ais20.MPAS_LISIO_JRA1p5.mpaso-ocn_glcshelf
  test to the MALI ais8to30 grid that was recently added. When the mesh
  was added, the test was failing due to issues with the thermal solver,
  but those have been resolved between MALI thermal solver bug fix and
  improved iceberg handling #6547 and this PR, so we can now update that
  test to the newer mesh.

[NML] for all configurations with MALI
[non-BFB] for all configurations with active MALI
@jonbob
Copy link
Contributor

jonbob commented Sep 5, 2024

Passes:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1
  • e3sm_landice_developer on chrysalis_gnu with expected DIFFs

Also successfully ran new test:

  • ERS_Ld5.TL319_oQU240wLI_ais8to30.MPAS_LISIO_JRA1p5.chrysalis_intel.mpaso-ocn_glcshelf

merged to next

@jonbob jonbob merged commit ccaa4b3 into master Sep 6, 2024
21 checks passed
@jonbob jonbob deleted the matthewhoffman/mali/enable_thermal_solver branch September 6, 2024 17:50
@jonbob
Copy link
Contributor

jonbob commented Sep 6, 2024

merged to master and expected DIFFs and NML DIFFs blessed except for mappy and pm-cpu_developer, which have not yet reported. But the new test is failing -- we probably will need to work on a new PR to change the test layouts as quickly as possible

@jonbob
Copy link
Contributor

jonbob commented Sep 9, 2024

The new test isn't failing -- a recent CIME update changed the behavior for BFAILs. A fix is being merged and I'll add bless requests for the new test as soon as it changes the dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-albany-landice NML Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants