Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3106: add analysis_tool_t::initialize() #3319

Merged
merged 2 commits into from
Dec 21, 2018
Merged

i#3106: add analysis_tool_t::initialize() #3319

merged 2 commits into from
Dec 21, 2018

Commits on Dec 20, 2018

  1. i#3106: add analysis_tool_t::initialize() 

    Adds a separate analysis_tool_t::initialize() method to better handle
tool initialization that can fail, separating it out from the
constructor.  This simplifies subclassing as well.

Updates the view_t and opcode_mix_t tools to move their module mapping
and other code into initialize().  Leaves updating the simulator tools
for future work.

Changes raw2trace_directory_t to return error strings instead of
aborting the process, and splits its constructor from new initialize()
and initialize_module_file() methods.

Fixes #3106
    @derekbruening
    derekbruening committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    c623ef8 View commit details
    Browse the repository at this point in the history

  2. Initialize module fields in new default constructor

    @derekbruening
    derekbruening committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    1926249 View commit details
    Browse the repository at this point in the history