i#3106: add analysis_tool_t::initialize() #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a separate analysis_tool_t::initialize() method to better handle tool initialization that can fail, separating it out from the constructor. This simplifies subclassing as well. Updates the view_t and opcode_mix_t tools to move their module mapping and other code into initialize(). Leaves updating the simulator tools for future work. Changes raw2trace_directory_t to return error strings instead of aborting the process, and splits its constructor from new initialize() and initialize_module_file() methods. Fixes #3106
|
Appveyor is non-det reuse_distance assert: |
|
The reuse_distance failure is #3320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate analysis_tool_t::initialize() method to better handle
tool initialization that can fail, separating it out from the
constructor. This simplifies subclassing as well.
Updates the view_t and opcode_mix_t tools to move their module mapping
and other code into initialize(). Leaves updating the simulator tools
for future work.
Changes raw2trace_directory_t to return error strings instead of
aborting the process, and splits its constructor from new initialize()
and initialize_module_file() methods.
Fixes #3106