Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential 2.4 dep viewer cherry picks #9922

Merged
merged 6 commits into from
Aug 20, 2019
Merged

potential 2.4 dep viewer cherry picks #9922

merged 6 commits into from
Aug 20, 2019

Commits on Aug 20, 2019

  1. DYN-1874: I want to download missing graph package dependencies easily ( 

    DynamoDS#9854)

* Add IPackageInfo interface

* Add IPackageInfo interface

* Add PackageManagerClient API to intiate download and install of a package

* Add download button to test package download

* Add IPackageInfo interface

* Use PD state

* Fix comment

* Refactor Dependency Viewer UI

* Rename ExecutePackage -> ExecutePackageDownload

* Add PackageManagerClientViewModel to ViewLoadedParams

* Add IPackageDownloader to LoadedViewParams

* Move messages to resource file

* Add state-based messages

* Font size

* Keep ReferenceType and INodeLibraryDepInfo internal

* IPackageDownloader.cs -> IPackageInstaller.cs

* IPackageInstaller comments

* Move details message to resx

* Fix resource conflict

* Check terms of use acceptance before downloading package

* Embed icons in resources.resx

* Remove raw resources

* Add summary to public class

* Add summaries for PackageDependencyRow members

(cherry picked from commit 8ca9d0f)
    @scottmitchell @mjkkirschner
    scottmitchell authored and mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    36e7217 View commit details
    Browse the repository at this point in the history

  2. merge conflict assemblyInfo

    @QilongTang @mjkkirschner
    QilongTang authored and mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    2ea592e View commit details
    Browse the repository at this point in the history

  3. remove unnecessary API

    @mjkkirschner
    mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    cdda7ca View commit details
    Browse the repository at this point in the history

  4. update dev view UI when package installed. (DynamoDS#9915) 

    * get rid of properties that were not set
set package loader to update dep UI
add this outisde the view to make it clear this is intended to be a singleton view

* flipped usings

(cherry picked from commit 9243c17)
    @mjkkirschner
    mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    1edb0c1 View commit details
    Browse the repository at this point in the history

  5. review comments

    @mjkkirschner
    mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    b74f5a3 View commit details
    Browse the repository at this point in the history

  6. sneaky equals

    @mjkkirschner
    mjkkirschner committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    4f8bfdf View commit details
    Browse the repository at this point in the history