potential 2.4 dep viewer cherry picks #9922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DynamoDS#9854) * Add IPackageInfo interface * Add IPackageInfo interface * Add PackageManagerClient API to intiate download and install of a package * Add download button to test package download * Add IPackageInfo interface * Use PD state * Fix comment * Refactor Dependency Viewer UI * Rename ExecutePackage -> ExecutePackageDownload * Add PackageManagerClientViewModel to ViewLoadedParams * Add IPackageDownloader to LoadedViewParams * Move messages to resource file * Add state-based messages * Font size * Keep ReferenceType and INodeLibraryDepInfo internal * IPackageDownloader.cs -> IPackageInstaller.cs * IPackageInstaller comments * Move details message to resx * Fix resource conflict * Check terms of use acceptance before downloading package * Embed icons in resources.resx * Remove raw resources * Add summary to public class * Add summaries for PackageDependencyRow members (cherry picked from commit 8ca9d0f)
* get rid of properties that were not set set package loader to update dep UI add this outisde the view to make it clear this is intended to be a singleton view * flipped usings (cherry picked from commit 9243c17)
mjkkirschner
changed the title
QilongTang
requested changes
Aug 20, 2019
|
@QilongTang updated - PTAL |
QilongTang
reviewed
Aug 20, 2019
|
One last comment, then LGTM. Once the checks are good, feel free to merge. Would love to get new RC localized and bang on it together. |
|
LGTM |
QilongTang
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
cherry picking latest dependency viewer updates.
Removing one API I don't think is required. @QilongTang
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@smangarole