[DYN-6455] Add warning text to selection node's initial warning #14833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: failure. 1 passed, 1 failed. |
|
But somehow warning bubble is still not enabled for selection nodes? |
@QilongTang For the warning bubble to appear we had to set persistent flag as true, or else the bubble is not update and the flow is returned at this line since the select face node is not involved in execution initially. But after setting the warning as persistent, the warning is shown even after an element is selected. |
QilongTang
approved these changes
Jan 16, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Passed, merging! |
|
@zeusongit Please cherry-pick this one to RC3.0.2 |
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Jan 17, 2024
…moDS#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Jan 17, 2024
…s initial warning (#14833) (#14856) * [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829) * Fix PostDiff job * Update NodeAutoCompleteSearchViewModel.cs * [DYN-6455] Add warning text to selection node's initial warning (#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code
QilongTang
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code
QilongTang
added a commit
that referenced
this pull request
Mar 1, 2024
* Re-work watch node display logic (#14841) * improvements (#14497) * [DYN-6455] Add warning text to selection node's initial warning (#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code * [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809) * Fix PostDiff job * Update DynamoView.xaml * Revert UI Blocking Function calls (#14766) * [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829) * Fix PostDiff job * Update NodeAutoCompleteSearchViewModel.cs * Update * DYN-5745 re enable copy/paste capabilities for library searchBar (#14492) * feat(library): keydown events binding and copy/paste for clipboard management * refactor(library): OnPasteFromClipboard function for clipboard management including comments * DYN-6364 Skip Lucene indexing process in UIless mode (#14523) * skip Lucene indexing process in UIless mode * Update comments --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Enzo Batista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add warning text to selection node's ghost warning.
Initially when no element is selected, the node state is in Warning state, but no text was displayed, this PR adds the text
Nothing selectedto the warning info state.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo