Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6067 Refine the node autocomplete ML confidence settings #14497

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Oct 18, 2023

Purpose

Per https://jira.autodesk.com/browse/DYN-6067, refine the node autocomplete ML confidence settings

  • Validate the confidence threshold setting being reflected in the ML results.
    NodeAutoCompleteMLConfidenceLevel

  • Rename it to Preferred confidence level
    image

  • Make the setting specific to Node Autocomplete ML UI, which means the toggle would control if a low confidence section will be displayed or not
    NodeAutoCompleteMLPreferredConfidenceLevelToggle

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Refine the node autocomplete ML confidence settings

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.0 milestone Oct 18, 2023
@reddyashish
Copy link
Contributor

@QilongTang just to confirm, when you select node type in preference, will the slider and no of results field be disabled?

@QilongTang
Copy link
Contributor Author

QilongTang commented Oct 19, 2023

@QilongTang just to confirm, when you select node type in preference, will the slider and no of results field be disabled?

@reddyashish Yes, that is still the case

@QilongTang
Copy link
Contributor Author

I believe Dynamo SelfServe passed before I addressed the merge conflicts, merging

@QilongTang QilongTang merged commit 172d7a5 into master Oct 20, 2023
25 checks passed
@QilongTang QilongTang deleted the NodeAutoCompleteMLIMP branch October 20, 2023 15:15
QilongTang added a commit that referenced this pull request Feb 29, 2024
@QilongTang QilongTang mentioned this pull request Feb 29, 2024
9 tasks
QilongTang added a commit that referenced this pull request Mar 1, 2024
* Re-work watch node display logic (#14841)

* improvements (#14497)

* [DYN-6455] Add warning text to selection node's initial warning (#14833)

* Fix PostDiff job

* Update Selection.cs

* made the warning persistent and then add removal code

* [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809)

* Fix PostDiff job

* Update DynamoView.xaml

* Revert UI Blocking Function calls (#14766)

* [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829)

* Fix PostDiff job

* Update NodeAutoCompleteSearchViewModel.cs

* Update

* DYN-5745 re enable copy/paste capabilities for library searchBar (#14492)

* feat(library): keydown events binding and copy/paste for clipboard management

* refactor(library): OnPasteFromClipboard function for clipboard management including comments

* DYN-6364 Skip Lucene indexing process in UIless mode (#14523)

* skip Lucene indexing process in UIless mode

* Update comments

---------

Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: Enzo Batista <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants