Dnenov packageintegration mypackages #14198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a WPF window for the new Package Manager - placed under Packages in the toolbar
- added basic ui affordances (close, move) - analytics track window events
- search tab functional
- moved the PackageManagerSearch functionality into a separate UserControl
- mirrored publish package view into a user control hosted inside the new Package Manager
- added back the search bar to the search package control
- a separate search control added to better manage the style
- implemented the Installed Packages tab
- window border of preferences/package manager change to match node border
- added UI tests for the Package Manager
- introduced a single PackageManagerViewModel containing all view models necessary for the separate functionalities of the PacakgeManager
- added initial tests for PackageManagerViewModel
- added test class for SearchBoxControlText control - minor changes
- changes to preferences view cause merge conflict, storing changes to attempt clean merge and introduce after
- changed PackageMnagerlientViewModel Owner type to Window, to allow for other controls to be set - changed how height is set for the InstalledPackagesControl to allow the control to display correctly inside larger windows
- added MyPackages controll - added warning navigation screen when no local packages are installed
- created a new Window owner of the PackageManagerClientViewModle to allow other Views to utilize it correctly
- now populates separately and is not linked to SearchResults (not influenced by search changes)
- added the loading animation screen (still WIP) - connected controls and visibility binding - since this particular animation cannot be set in style, created custom control for the loading stripe
- introduced a separate property to only flip once the initial results are loaded
- added the remaining animation stripes covering the search and filter buttons in the search view
- created the timedout screen and mocked up a timed-out workflow
- first stab at making the package details view extension work with the new package manager
- removed installed packages from the Preferences Panel - renamed Package Manager to Package Settings
…egration-mypackages
- modified timed out screen to allow for multiple choices of action
- link package manager with preferences panel with back-and-forth links between connected functionalities - still working on the loading timed out workflow
- transformed the loading timed out warning into a toast row, which is part of the search control - the timed out warning will appear after certain amount of time has elapsed as specified inside the MAX_LOAD_TIME variable - the timed out warning will disappear (if shown) after the results have been loaded - removed old code
- work out the way to utilize the PackageDetailsExtension with the ability to host inside a dedicated grid column - making sure only 1 instance of the extension is being used at a time - disposing of the necessary objects associated with the extension when closing the PackageManagerView
- added remaining string values to localized resources
…egration-mypackages
- removed package manager search and publish package from the Dynamo menu - localized package manager menu item
- I was removing unnecessary namespaces, I may have to go back to previous state if this doesn't work
reddyashish
reviewed
Jul 25, 2023
- changed max loading time value to 30 seconds - added the ability to copy currently selected package path value to clipboard
…egration-mypackages
- restored accidental changes to AssemblySharedInfo - copied line from current Master
- restored accidental changes to AssemblySharedInfo - copied line from current Master
|
@reddyashish @dnenov When are we going to split the follow up improvements into another PR? In general I am scared of huge PRs :) |
|
Yes, it is a big one, isn't it :/ I will check in with @reddyashish to see what's the best way to split it up! |
…-packageintegration-mypackages
…egration-mypackages
|
Thanks @dnenov @reddyashish Maybe we can review this one as it is and leave other improvements on another PR. What do you think? |
This was referenced Aug 16, 2023
|
This can now be closed, all the parts that made up this PR have been successfully merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged. Currently broken down in separate PRs.
Purpose
This is a follow-up PR on the package integration PR. It builds on the continuous design guides as per this Figma link.
Even though a lot of areas have been improved, this is still work in progress. With the main skeleton of the solution in place, the major directions of work are:
Screenshots
01 loading screen
02 discard loading timeout
03 package details extension interaction
04 package manager contents
05 package manager to preferences interaction
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Progression work on the Package Manager
Reviewers
@reddyashish
@QilongTang
FYIs
@Amoursol