Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnenov packageintegration #14075

Merged
merged 24 commits into from
Jul 6, 2023
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jun 14, 2023

Purpose

This is the the first part of a series of PRs dedicated to the update of the Dynamo package manager. The goal behind the update is to host all package-related functions under one single UI element. For more (visual) information on the whole scope of the task, follow the Figma link here.

This PR contains the initial skeleton of the UI, collecting existing functionalities in one spot and creating the ground work for the different aspects of the update.

Screenshots

Tab 1 - Search for Packages

image

Tab 2 - Publish a Package

image

Tab 3 - Installed Packages

image

Tab 4 - My Packages (emtpy at the moment)

image

Tab 5 - Package Settings

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • created initial Package Manager View containing the separate functionalities (tabs)
  • reused existing controls, where possible, creating User Controls
  • created new User Controls
  • single View Model containing all separate View Models used for the individual controls
  • added unit and system tests for new functionalities (old view models were reused as is)
  • new style dictionary specific to the Package Manager added

Reviewers

@reddyashish
@QilongTang

FYIs

@Amoursol

dnenov added 17 commits May 24, 2023 16:36
- created a WPF window for the new Package Manager
-  placed under Packages in the toolbar
- added basic ui affordances (close, move)
- analytics track window events
- search tab functional
- moved the PackageManagerSearch functionality into a separate UserControl
- mirrored publish package view into a user control hosted inside the new Package Manager
- added back the search bar to the search package control
- a separate search control added to better manage the style
- implemented the Installed Packages tab
- window border of preferences/package manager change to match node border
- moved location of packagemanger to be under the packagemanager folder in the DynamoCoreWpf project
- added UI tests for the Package Manager
- introduced a single PackageManagerViewModel containing all view models necessary for the separate functionalities of the PacakgeManager
- added initial tests for PackageManagerViewModel
- code refactor and clean-up
- added test class for SearchBoxControlText control
- minor changes
@dnenov
Copy link
Collaborator Author

dnenov commented Jun 14, 2023

Having trouble merging upstream/master.

- changes to preferences view cause merge conflict, storing changes to attempt clean merge and introduce after
@dnenov
Copy link
Collaborator Author

dnenov commented Jun 15, 2023

Having trouble merging upstream/master.

Reverted changes to PreferencesView.xaml causing the conflict. Will introduce the changes in a separate PR.

@dnenov
Copy link
Collaborator Author

dnenov commented Jun 15, 2023

User-facing resources will be resolved in a follow-up PR.

@dnenov dnenov marked this pull request as ready for review June 15, 2023 09:59
- changed PackageMnagerlientViewModel Owner type to Window, to allow for other controls to be set
- changed how height is set for the InstalledPackagesControl to allow the control to display correctly inside larger windows
- created a new Window owner of the PackageManagerClientViewModle to allow other Views to utilize it correctly
@QilongTang QilongTang added this to the 2.19.0 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants