-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnenov packageintegration #14075
Merged
reddyashish
merged 24 commits into
DynamoDS:master
from
dnenov:dnenov-packageintegration
Jul 6, 2023
Merged
Dnenov packageintegration #14075
reddyashish
merged 24 commits into
DynamoDS:master
from
dnenov:dnenov-packageintegration
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a WPF window for the new Package Manager - placed under Packages in the toolbar
- added basic ui affordances (close, move) - analytics track window events
- search tab functional
- moved the PackageManagerSearch functionality into a separate UserControl
- mirrored publish package view into a user control hosted inside the new Package Manager
- added back the search bar to the search package control
- a separate search control added to better manage the style
- implemented the Installed Packages tab
- window border of preferences/package manager change to match node border
- added UI tests for the Package Manager
- introduced a single PackageManagerViewModel containing all view models necessary for the separate functionalities of the PacakgeManager
- added initial tests for PackageManagerViewModel
- added test class for SearchBoxControlText control - minor changes
Having trouble merging upstream/master. |
- changes to preferences view cause merge conflict, storing changes to attempt clean merge and introduce after
Reverted changes to PreferencesView.xaml causing the conflict. Will introduce the changes in a separate PR. |
User-facing resources will be resolved in a follow-up PR. |
- changed PackageMnagerlientViewModel Owner type to Window, to allow for other controls to be set - changed how height is set for the InstalledPackagesControl to allow the control to display correctly inside larger windows
reddyashish
reviewed
Jun 22, 2023
src/GraphNodeManagerViewExtension/Controls/SearchBoxControl.xaml
Outdated
Show resolved
Hide resolved
reddyashish
reviewed
Jun 22, 2023
reddyashish
reviewed
Jun 22, 2023
src/DynamoCoreWpf/Views/PackageManager/Controls/ControlColorsAndBrushes.xaml
Outdated
Show resolved
Hide resolved
reddyashish
reviewed
Jun 22, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs
Outdated
Show resolved
Hide resolved
- created a new Window owner of the PackageManagerClientViewModle to allow other Views to utilize it correctly
reddyashish
approved these changes
Jul 6, 2023
9 tasks
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is the the first part of a series of PRs dedicated to the update of the Dynamo package manager. The goal behind the update is to host all package-related functions under one single UI element. For more (visual) information on the whole scope of the task, follow the Figma link here.
This PR contains the initial skeleton of the UI, collecting existing functionalities in one spot and creating the ground work for the different aspects of the update.
Screenshots
Tab 1 - Search for Packages
Tab 2 - Publish a Package
Tab 3 - Installed Packages
Tab 4 - My Packages (emtpy at the moment)
Tab 5 - Package Settings
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@reddyashish
@QilongTang
FYIs
@Amoursol