Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-4513 Improvement: Allow pin note to node via drag, hover and release #13966

Merged
merged 3 commits into from
May 9, 2023
Merged

DYN-4513 Improvement: Allow pin note to node via drag, hover and release #13966

merged 3 commits into from
May 9, 2023

Commits on May 4, 2023

  1. Note over Node hover visuals 

    - will highlight Node when a Note is being hovered over it
    @dnenov
    dnenov committed May 4, 2023
    Configuration menu
    Copy the full SHA
    18700a0 View commit details
    Browse the repository at this point in the history

  2. Exclude unwanted cases, refactor 

    - moved the new functionality into a separate method, as it was getting a bit too long
- now only handles the case of a note being dragged over a node
    @dnenov
    dnenov committed May 4, 2023
    Configuration menu
    Copy the full SHA
    6271ec1 View commit details
    Browse the repository at this point in the history

  3. Pins note on release 

    - now successfully pins the note when the mouse is released and the note is over the node
- will skip highlighting Nodes that already have a Note pinned (consistent with current behavior to not allow more than 1 pinned Note)
    @dnenov
    dnenov committed May 4, 2023
    Configuration menu
    Copy the full SHA
    e32a920 View commit details
    Browse the repository at this point in the history