Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4513 Improvement: Allow pin note to node via drag, hover and release #13966

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 4, 2023

Purpose

An improvement allowing the user to drag-&-drop a Note over a Node, pinning it down. Below is the description of the task as set in the brief:

pin note to node

pin note drag   drop

border update on hover state

hover note over node

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

The steps taken to create the new functionality are as follows:

  • created new graphic affordances to show a hover state over a Node
  • created the logic inside the StateMachine that handles the case of Note being hovered over a Node
  • successfully pins the note when the mouse is released and the note is over the node
  • will skip highlighting Nodes that already have a Note pinned (consistent with current behavior to not allow more than 1 pinned Note)

Reviewers

@reddyashish
@Amoursol

FYIs

dnenov added 3 commits May 4, 2023 15:19
- will highlight Node when a Note is being hovered over it
- moved the new functionality into a separate method, as it was getting a bit too long
- now only handles the case of a note being dragged over a node
- now successfully pins the note when the mouse is released and the note is over the node
- will skip highlighting Nodes that already have a Note pinned (consistent with current behavior to not allow more than 1 pinned Note)
@dnenov dnenov marked this pull request as ready for review May 4, 2023 16:14
@QilongTang QilongTang added this to the 2.19.0 milestone May 9, 2023
@reddyashish
Copy link
Contributor

The failing test is a flaky one. We will need a UI automation test for this feature. Will add a task for that and merging this.

@reddyashish reddyashish merged commit 7b0b7fd into DynamoDS:master May 9, 2023
@Amoursol
Copy link
Contributor

@reddyashish did this make it into 2.18, or is it targeted for 2.19?

@reddyashish
Copy link
Contributor

This is in 2.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants