-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5319 #13441
Merged
Merged
DYN-5319 #13441
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1e5b06c
ADDED: Dynamo Preference Settings API to add, query, and remove Dynam…
LongNguyenP 6a61ace
Made the dict public and removed related methods
LongNguyenP bf9aebd
Reverted assembly version change
LongNguyenP 953d649
Added ///summary for DynamoPlayerFolderItem class
LongNguyenP ea02d36
Merge branch 'master' into DYN-5319
LongNguyenP 7cac2be
Merge branch 'master' into DYN-5319
saintentropy 440be3b
Move away from using Dictionary
saintentropy 0eb384b
missing public
saintentropy 9faa289
Update test
saintentropy c26cc07
Merge remote-tracking branch 'origin/DYN-5319' into DYN-5319
LongNguyenP 4ddcbc3
Fixed TestImportCopySettings failure
LongNguyenP 0e16b14
Updated TestSettingsSerialization to include testing for the new Dyna…
LongNguyenP 5d2003b
Added some initial data for the test DynamoPlayerFolder object
LongNguyenP 37c6612
PR comments
saintentropy a46b754
Remove all constructors as they are not really neccesary
LongNguyenP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
using System.Collections.Generic; | ||
|
||
namespace Dynamo.Configuration | ||
{ | ||
/// <summary> | ||
/// This class describes a folder (usually containing Dynamo graphs) added to the Dynamo Player or Generative Design | ||
/// </summary> | ||
public class DynamoPlayerFolder | ||
{ | ||
/// <summary> | ||
/// The full path if the folder | ||
LongNguyenP marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// </summary> | ||
public string Path; | ||
|
||
/// <summary> | ||
/// The display name of the folder | ||
/// </summary> | ||
public string DisplayName; | ||
|
||
/// <summary> | ||
/// The ID of the folder | ||
/// </summary> | ||
public string Id; | ||
|
||
/// <summary> | ||
/// Whether this folder is removable from the settings (Built-in folders are non-removable) | ||
/// </summary> | ||
public bool IsRemovable = true; | ||
|
||
/// <summary> | ||
/// The order of the folder | ||
/// </summary> | ||
public int Order = -1; | ||
|
||
/// <summary> | ||
/// Initialize a DynamoPlayerFolderItem | ||
/// </summary> | ||
/// <param name="path">The full path of the folder</param> | ||
/// <param name="displayName">The display name of the folder</param> | ||
/// <param name="id">The id of the folder</param> | ||
/// <param name="isRemovable">The removalbe state of the folder</param> | ||
/// <param name="order">The order of the folder in the UI</param> | ||
public DynamoPlayerFolder(string path, string displayName, string id, bool isRemovable, int order) | ||
{ | ||
Path = path; | ||
DisplayName = displayName; | ||
Id = id; | ||
IsRemovable = isRemovable; | ||
Order = order; | ||
} | ||
|
||
/// <summary> | ||
/// Create an empty DynamoPlayerFolderItem | ||
/// </summary> | ||
public DynamoPlayerFolder() | ||
LongNguyenP marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
|
||
} | ||
} | ||
|
||
/// <summary> | ||
/// This Class defines a group of folders assciated with a Dynamo Player or Generative Design entry point. | ||
/// </summary> | ||
public class DynamoPlayerFolderGroup | ||
{ | ||
/// <summary> | ||
/// The name of the Player entry point | ||
/// </summary> | ||
public string EntryPoint; | ||
|
||
/// <summary> | ||
/// The List of Folder Items for this group | ||
/// </summary> | ||
public List<DynamoPlayerFolder> Folders; | ||
|
||
/// <summary> | ||
/// Creates an empty DynamoPlayerFolderGroup | ||
/// </summary> | ||
public DynamoPlayerFolderGroup() | ||
{ | ||
Folders = new List<DynamoPlayerFolder>(); | ||
} | ||
|
||
/// <summary> | ||
/// Initialize a DynamoPlayerFolderItem | ||
/// </summary> | ||
/// <param name="entryPoint">The name of the Player entry point</param> | ||
/// <param name="folders">The list of Folder data</param> | ||
public DynamoPlayerFolderGroup(string entryPoint, List<DynamoPlayerFolder> folders) | ||
{ | ||
EntryPoint = entryPoint; | ||
Folders = folders; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid committing this without a good reason, it causes conflicts etc as the file is autogenerated.