Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5319 #13441

Merged
merged 15 commits into from
Nov 9, 2022
Merged

DYN-5319 #13441

merged 15 commits into from
Nov 9, 2022

Conversation

LongNguyenP
Copy link
Contributor

Purpose

This PR implements DYN-5319](https://jira.autodesk.com/browse/DYN-5319):

  • Add to the Dynamo Preference Settings a dictionary to store the folder collections that are used by DynamoPlayer or GD as entry-point.
  • Add API for querying, adding, and remove the data from this dictionary.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Dynamo Preference Settings now include information about the user-folders in Dynamo Player and Generative Design

Reviewers

@mjkkirschner @QilongTang @saintentropy

@QilongTang
Copy link
Contributor

@LongNguyenP Changes looks fine, but would only guarantee the preference settings serialization/deserialization works, you may need to apply additional changes to make sure setting import/export works, e.g. #13476

@@ -45,7 +45,7 @@
// to distinguish one build from another. AssemblyFileVersion is specified
// in AssemblyVersionInfo.cs so that it can be easily incremented by the
// automated build process.
[assembly: AssemblyVersion("2.17.0.2986")]
[assembly: AssemblyVersion("2.17.0.3065")]
Copy link
Member

@mjkkirschner mjkkirschner Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid committing this without a good reason, it causes conflicts etc as the file is autogenerated.

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay to me -

I think in general you should not use public fields like you have done and instead use auto properties if there is not a good reason.

https://softwareengineering.stackexchange.com/questions/161303/is-it-bad-practice-to-use-public-fields#:~:text=If%20you%20start%20out%20with,switch%20to%20property%2Dbased%20access.

it's also part of the MSDN c# coding conventions.

@LongNguyenP LongNguyenP merged commit 89db1f7 into master Nov 9, 2022
@LongNguyenP LongNguyenP deleted the DYN-5319 branch November 9, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants