-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5319 #13441
DYN-5319 #13441
Conversation
…o Player entry-point folders
# Conflicts: # src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs
# Conflicts: # src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs
…moPlayerFolderGroups
@LongNguyenP Changes looks fine, but would only guarantee the preference settings serialization/deserialization works, you may need to apply additional changes to make sure setting import/export works, e.g. #13476 |
@@ -45,7 +45,7 @@ | |||
// to distinguish one build from another. AssemblyFileVersion is specified | |||
// in AssemblyVersionInfo.cs so that it can be easily incremented by the | |||
// automated build process. | |||
[assembly: AssemblyVersion("2.17.0.2986")] | |||
[assembly: AssemblyVersion("2.17.0.3065")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid committing this without a good reason, it causes conflicts etc as the file is autogenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks okay to me -
I think in general you should not use public fields like you have done and instead use auto properties if there is not a good reason.
it's also part of the MSDN c# coding conventions.
Purpose
This PR implements DYN-5319](https://jira.autodesk.com/browse/DYN-5319):
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Dynamo Preference Settings now include information about the user-folders in Dynamo Player and Generative Design
Reviewers
@mjkkirschner @QilongTang @saintentropy