DAO Improvements #12
Merged
DAO Improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still possible to simplify governor base contract for execute set of functions Deployment cost down by 50% compared to timelock #11
removed duplicate code, downgraded abstraction improvement of 1% DeployC in GovernorContract (5728315) #11
adjusted addon contracts that no longer need token integration removed voting delay and proposalThreashold set maximum voting power in userRegistry voting power is directly related to member info (percentage) update ProposalStates (removed unnecesary) update cancel requirements (any time but cannot already have a vote) removed snapshots of past voting power and quorum history quorum is hardcoded in main contract for now introducing dev member in DAO in deployment for development porposes added member count variable to userRegistry for future infVisual removed ProposalCore struct gaps updated state logic votes only uint8 removed Context contract from Governor, using msg.sender directly removed getVotesWithParams removed valid description checks since idea should be using IPFS for cost reduction and there should be no mempool war, we want to resolve fast using timestamps for clock in EIP-6372 for votes updated several contracts for use of interfaces update deployment scripts fix: increasing time not working test: fixed existing tests #11
0.8% of the limit imporve in deployment cost #11
removed util contract for EIP712 (structured hashing and signatures) reduction of deployment cost by 2.1% (total at 11.1%) for GovernorContract #11
reduction of 1.5% (total 9.6%) of GovernorContract deploy cost #11
…method all funds should be in executor reduction of 0.6% (9% total) in contract size #11
deployment and methods #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue, closes #11 .
Improvements and simplifications to the OpenZeppelin version of governance. Aiming to improve deployment and execution cost.