Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAO improvements #11

Closed
DuBento opened this issue Jul 19, 2023 · 0 comments · Fixed by #12
Closed

DAO improvements #11

DuBento opened this issue Jul 19, 2023 · 0 comments · Fixed by #12
Labels
feat

Comments

@DuBento
Copy link
Owner

DuBento commented Jul 19, 2023

Mainly deployment gas reductions.
Moving from Openzeppelin contracts to custom version.
@DuBento DuBento added the feat label Jul 19, 2023
DuBento added a commit that referenced this issue Jul 19, 2023
@DuBento
feat: governor without OZ timelock. Default governor executer
99a161e 
#11
DuBento added a commit that referenced this issue Jul 23, 2023
@DuBento
feat: separate to custom version of Governor contract
9234bdc 
#11
DuBento added a commit that referenced this issue Jul 24, 2023
@DuBento
feat: simple executor contract and governorExecutor extension
211dec4 
Still possible to simplify governor base contract for execute set of functions
Deployment cost down by 50% compared to timelock
#11
DuBento added a commit that referenced this issue Jul 25, 2023
@DuBento
feat: GovernorExecutor as default inheritance for governor
de7a38c 
removed duplicate code, downgraded abstraction
improvement of 1% DeployC in GovernorContract (5728315)
#11
DuBento added a commit that referenced this issue Jul 25, 2023
@DuBento
feat: Executor receive method
4434457 
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
feat: removed Token from DAO and other mixed improvements
647e4de 
adjusted addon contracts that no longer need token integration
removed voting delay and proposalThreashold
set maximum voting power in userRegistry
voting power is directly related to member info (percentage)
update ProposalStates (removed unnecesary)
update cancel requirements (any time but cannot already have a vote)
removed snapshots of past voting power and quorum history
quorum is hardcoded in main contract for now
introducing dev member in DAO in deployment for development porposes
added member count variable to userRegistry for future infVisual
removed ProposalCore struct gaps
updated state logic
votes only uint8
removed Context contract from Governor, using msg.sender directly
removed getVotesWithParams
removed valid description checks since idea should be using IPFS for cost reduction and there should be no mempool war, we want to resolve fast
using timestamps for clock in EIP-6372 for votes
updated several contracts for use of interfaces
update deployment scripts
fix: increasing time not working
test: fixed existing tests
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
feat: remove methods with support for additional params
a90aded 
0.8% of the limit imporve in deployment cost
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
feat: remove voting with pre-signed message
d789a34 
removed util contract for EIP712 (structured hashing and signatures)
reduction of deployment cost by 2.1% (total at 11.1%) for GovernorContract
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
feat: remove token receive support
1b1be9e 
reduction of 1.5% (total 9.6%) of GovernorContract deploy cost
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
feat: remove receive method support from Governor contract and relay …
4b9f098 
…method

all funds should be in executor
reduction of 0.6% (9% total) in contract size
#11
DuBento added a commit that referenced this issue Jul 28, 2023
@DuBento
report: new gas values and comparation
19f8726 
deployment and methods
#11
@DuBento DuBento mentioned this issue Jul 30, 2023
Merged
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: governor without OZ timelock. Default governor executer
bd85595 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: separate to custom version of Governor contract
d4a0884 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: simple executor contract and governorExecutor extension
f175964 
Still possible to simplify governor base contract for execute set of functions
Deployment cost down by 50% compared to timelock
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: GovernorExecutor as default inheritance for governor
1a56fcc 
removed duplicate code, downgraded abstraction
improvement of 1% DeployC in GovernorContract (5728315)
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: Executor receive method
102b34c 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: removed Token from DAO and other mixed improvements
de391f9 
adjusted addon contracts that no longer need token integration
removed voting delay and proposalThreashold
set maximum voting power in userRegistry
voting power is directly related to member info (percentage)
update ProposalStates (removed unnecesary)
update cancel requirements (any time but cannot already have a vote)
removed snapshots of past voting power and quorum history
quorum is hardcoded in main contract for now
introducing dev member in DAO in deployment for development porposes
added member count variable to userRegistry for future infVisual
removed ProposalCore struct gaps
updated state logic
votes only uint8
removed Context contract from Governor, using msg.sender directly
removed getVotesWithParams
removed valid description checks since idea should be using IPFS for cost reduction and there should be no mempool war, we want to resolve fast
using timestamps for clock in EIP-6372 for votes
updated several contracts for use of interfaces
update deployment scripts
fix: increasing time not working
test: fixed existing tests
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove methods with support for additional params
d043009 
0.8% of the limit imporve in deployment cost
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove voting with pre-signed message
3d6d60b 
removed util contract for EIP712 (structured hashing and signatures)
reduction of deployment cost by 2.1% (total at 11.1%) for GovernorContract
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove token receive support
3329306 
reduction of 1.5% (total 9.6%) of GovernorContract deploy cost
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove receive method support from Governor contract and relay …
d8d92fc 
…method

all funds should be in executor
reduction of 0.6% (9% total) in contract size
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
report: new gas values and comparation
55a8b9e 
deployment and methods
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: governor without OZ timelock. Default governor executer
f06c81d 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: separate to custom version of Governor contract
c1c48cf 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: simple executor contract and governorExecutor extension
2e199e1 
Still possible to simplify governor base contract for execute set of functions
Deployment cost down by 50% compared to timelock
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: GovernorExecutor as default inheritance for governor
af2181b 
removed duplicate code, downgraded abstraction
improvement of 1% DeployC in GovernorContract (5728315)
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: Executor receive method
74db6d9 
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: removed Token from DAO and other mixed improvements
2114a48 
adjusted addon contracts that no longer need token integration
removed voting delay and proposalThreashold
set maximum voting power in userRegistry
voting power is directly related to member info (percentage)
update ProposalStates (removed unnecesary)
update cancel requirements (any time but cannot already have a vote)
removed snapshots of past voting power and quorum history
quorum is hardcoded in main contract for now
introducing dev member in DAO in deployment for development porposes
added member count variable to userRegistry for future infVisual
removed ProposalCore struct gaps
updated state logic
votes only uint8
removed Context contract from Governor, using msg.sender directly
removed getVotesWithParams
removed valid description checks since idea should be using IPFS for cost reduction and there should be no mempool war, we want to resolve fast
using timestamps for clock in EIP-6372 for votes
updated several contracts for use of interfaces
update deployment scripts
fix: increasing time not working
test: fixed existing tests
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove methods with support for additional params
74cbef7 
0.8% of the limit imporve in deployment cost
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove voting with pre-signed message
1dfd335 
removed util contract for EIP712 (structured hashing and signatures)
reduction of deployment cost by 2.1% (total at 11.1%) for GovernorContract
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove token receive support
c5c79ac 
reduction of 1.5% (total 9.6%) of GovernorContract deploy cost
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
feat: remove receive method support from Governor contract and relay …
23acbb1 
…method

all funds should be in executor
reduction of 0.6% (9% total) in contract size
#11
DuBento added a commit that referenced this issue Jul 30, 2023
@DuBento
report: new gas values and comparation
269110b 
deployment and methods
#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DAO Improvements DuBento/Tracer
1 participant
@DuBento