Add "Show splash view" to debug menu #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. My PR may conflict #329 ... |
|
Sorry, can you resolve? 🙇 |
# Conflicts: # app/src/main/java/io/github/droidkaigi/confsched2017/view/activity/SplashActivity.java
|
I resolved conflict 😸 |
konifar
reviewed
Feb 14, 2017
| @@ -86,6 +86,11 @@ | |||
| android:theme="@style/AppTheme.ColoredStatusBar" | |||
| /> | |||
|
|
|||
| <activity | |||
| android:name=".view.activity.SplashViewActivity" | |||
There was a problem hiding this comment.
I think SplashDemoActivity is better name.
What do you think?
konifar
reviewed
Feb 14, 2017
| @@ -39,6 +40,9 @@ | |||
| NotificationStrategy notificationStrategy; | |||
|
|
|||
| @Inject | |||
| ShowSplashStrategy showSplashStrategy; | |||
There was a problem hiding this comment.
I think it's not good to add many debug menu to debot 🤔
No need to fix on this PR. But I might arrange the debug / developer menu later.
|
LGTM! Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Main
Other
I encountered leak of SplashActivity and I commit 9bfd0be to fix the leak.The leak may be resolved by #329 .
Links
N/A
Screenshot