Separate the logic for animating the ParticleView into SplashFragment. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
Make sense. I agree your opinion |
konifar
reviewed
Feb 13, 2017
|
|
||
| <io.github.droidkaigi.confsched2017.view.customview.ParticlesAnimationView | ||
| android:id="@+id/particle_animation_view" | ||
| <FrameLayout |
There was a problem hiding this comment.
Is this <FrameLayout> necessary?
DataBinding <layout> tag requires root view?
|
LGTM 💯 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)
Currently SplashActivity has 2 responsibility:
I think it would be more useful if the logic of animation is capsulized in a Fragment.
This Pull Request provides
SplashFragmentfor handling the ParticleView, and makes SplashActivity simpler.Links
Screenshot
not changed. Just a refactoring :)