Some clean-up #125
Merged
Some clean-up #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since optional dependencies automatically become features, there's no need to have a two-layer naming scheme for the drivers. Just use the drivers' package name.
Added "dep:" to optional dependencies that shouldn't be enabled by themselves.
Now the crates only pull in features they use from their dependencies. I thought this would reduce the size of the executable, but it didn't. Apparently the `lto` option does a very good job at removing unused code. However, it does reduce the link time because the `lto` option doesn't have to do as much work.
The `Store` trait is now only used in `drmemd`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize features used in dependent crates. Move
Storetrait intodrmemd.