Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Store trait from drmem-api crate #124

Closed
rneswold opened this issue Aug 18, 2024 · 0 comments · Fixed by #125
Closed

Remove Store trait from drmem-api crate #124

rneswold opened this issue Aug 18, 2024 · 0 comments · Fixed by #125
Labels
backend Issue is about backend storage difficulty:easy Issue should be easy to fix good first issue Good for newcomers refactor Code works but could be written better
Milestone
Release v0.5.0

Comments

@rneswold
Copy link
Contributor

In the v0.4.0 release, I put both the simple and redis back-ends in the drmemd source tree. Having them as external crates was silly because no other project was going to use them. After the merge, I forgot to remove the Trait from the drmem-api crate.

Either the trait needs to be moved into the drmemd source or, maybe, just conditionally using one of the modules is enough and the trait can be deleted.

The drmem-api crate is mainly for writing drivers, at this point.
@rneswold rneswold added good first issue Good for newcomers refactor Code works but could be written better backend Issue is about backend storage difficulty:easy Issue should be easy to fix labels Aug 18, 2024
@rneswold rneswold added this to the Release v0.5.0 milestone Aug 18, 2024
@rneswold rneswold linked a pull request Aug 18, 2024 that will close this issue
Some clean-up #125
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issue is about backend storage difficulty:easy Issue should be easy to fix good first issue Good for newcomers refactor Code works but could be written better
Projects
None yet
Milestone
Release v0.5.0
Development

Successfully merging a pull request may close this issue.

Some clean-up rneswold/drmem
1 participant
@rneswold