Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move preact to peerDependencies #19

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Move preact to peerDependencies #19

merged 2 commits into from
Jul 22, 2017

Conversation

avaly
Copy link

@avaly avaly commented Jul 13, 2017

This gives control over the version of preact to the parent project which uses this project.

Otherwise, if the main project is using preact version 8+, then a bundle would contain both the preact 8+ from the main project and the preact 7.1.0 from this project.

Note: Fixing the preact-render-to-string to 3.5.0, because 3.6.0 introduced some changes to who self closing tags are rendered and tests began failing.

@avaly
Copy link
Author

avaly commented Jul 16, 2017

I've also upgraded preact-side-effect with the latest version, which contains a similar move of preact to peerDependencies: ooade/preact-side-effect#7

@ooade ooade merged commit ee12d45 into Download:master Jul 22, 2017
@avaly
Copy link
Author

avaly commented Jul 22, 2017

@Download, @ooade can you also publish a new version to npm?

@ooade
Copy link
Collaborator

ooade commented Jul 23, 2017

@avaly V4 alpha 3 released

@avaly
Copy link
Author

avaly commented Jul 27, 2017

@Download, @ooade ⬆️ that version didn't get published to npm.

@ooade
Copy link
Collaborator

ooade commented Jul 27, 2017

@avaly i guess so 😅
Waiting on @Download for this

@Download
Copy link
Owner

Download commented Jul 31, 2017

@ooade I added you to the NPM collaborators so you should be able to publish now.
Let me know if you have any issues. 👍

EDIT: It is possible to delete GitHub releases, but probably the easiest thing to do is just to go to version 4.0.0-alpha-4 and skip alpha-3.

@ooade
Copy link
Collaborator

ooade commented Jul 31, 2017

@Download Thanks
@avaly Done :)

@Download
Copy link
Owner

Download commented Aug 1, 2017

@avaly Thanks for your contribution! 👍 You deserve a medal! 🥇 😉
@ooade Thank you for merging and releasing it! . ❤️

On another note. I guess this contribution is the result of you using preact-helmet in your project. So maybe you can provide some feedback on whether you think it is ready for v4.0.0-Final?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants