-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0 Final #28
Comments
I'll send a PR to resolve this, then we move to v4.0.0 :) |
I'm sorta hoping to get some feedback from @avaly and @siddharthkp as well. |
We're are using this on production and I think it's pretty solid. |
I am using this in a project, but it's not yet live in production. But from the integration tests I have for it, it seems to work fine! |
Great to hear guys! |
@Download , would you be open to adding typscript definition? I can submit a PR if you want to. I'm currently using this lib with typescript in a project. |
Also, is it possible to remove |
@sammkj At the moment, object-assign is still used explicitly. I guess we would have to rewrite that code to use About the Typescript definition: Definitely! Please make a PR if you will! It would be nice to include these in v4.0.0 Final. |
Inviting all active users of preact-helmet to give some feedback.
Is it ready for 4.0.0?
Please add a remark below.
Note: React-Helmet is at v5 and there is development going on to implement that. But it would be nice to release the current version as 4.0.0 before we move on imho.
The text was updated successfully, but these errors were encountered: