Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0 Final #28

Open
Download opened this issue Aug 1, 2017 · 8 comments
Open

v4.0 Final #28

Download opened this issue Aug 1, 2017 · 8 comments

Comments

@Download
Copy link
Owner

Download commented Aug 1, 2017

Inviting all active users of preact-helmet to give some feedback.

Is it ready for 4.0.0?

Please add a remark below.

Note: React-Helmet is at v5 and there is development going on to implement that. But it would be nice to release the current version as 4.0.0 before we move on imho.

@ooade
Copy link
Collaborator

ooade commented Aug 2, 2017

I'll send a PR to resolve this, then we move to v4.0.0 :)

@Download
Copy link
Owner Author

Download commented Aug 3, 2017

I'm sorta hoping to get some feedback from @avaly and @siddharthkp as well.
But I agree with you probably it's good to go now.

@siddharthkp
Copy link
Collaborator

We're are using this on production and I think it's pretty solid.

@avaly
Copy link

avaly commented Aug 3, 2017

I am using this in a project, but it's not yet live in production. But from the integration tests I have for it, it seems to work fine!

@Download
Copy link
Owner Author

Download commented Aug 4, 2017

Great to hear guys!

@kokjinsam
Copy link

@Download , would you be open to adding typscript definition? I can submit a PR if you want to. I'm currently using this lib with typescript in a project.

@kokjinsam
Copy link

Also, is it possible to remove object-assign dependency? Users of this lib can use babel-preset-env to add polyfill.

@Download
Copy link
Owner Author

Download commented Dec 9, 2017

@sammkj At the moment, object-assign is still used explicitly. I guess we would have to rewrite that code to use Object.assign... I'd be willing to change that if you make a PR.

About the Typescript definition: Definitely! Please make a PR if you will!

It would be nice to include these in v4.0.0 Final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants