Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing External Predictions, Dummy Learners, and Nuisance Estimation Updates #221

Merged
merged 72 commits into from
Dec 11, 2023

Conversation

JanTeichertKluge
Copy link
Member

@JanTeichertKluge JanTeichertKluge commented Dec 7, 2023

Description

This pull request introduces various changes related to external predictions. The major updates include:

  1. External Predictions:

    • Added support for external predictions in various models, including PLR, IRM, PLIV, IIVM, DID, DIDCS, PQ and LPQ
  2. Utils Submodule Addition:

    • Introduced a new utils submodule with dummy learners.
    • Improved dummy learners, now inheriting from the sklearn BaseEstimator for using external predictions.
  3. Update conditional targets for IRM.

These changes collectively enhance the functionality and maintainability of the package.

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new features are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@JanTeichertKluge JanTeichertKluge self-assigned this Dec 8, 2023
Copy link
Member

@SvenKlaassen SvenKlaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jan. Looks fine.

@SvenKlaassen SvenKlaassen self-requested a review December 11, 2023 09:08
@SvenKlaassen SvenKlaassen merged commit 1773384 into main Dec 11, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants