Added external predictions for PLR model #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
There was a problem hiding this comment.
Why do we need this ignore?
There was a problem hiding this comment.
I have tested other things besides the Unittest/PyTest, but I did not want to track the script for this, so it should be ignored. I can also move this script to another folder so that it is untracked.
There was a problem hiding this comment.
Yes, that might be preferable. Or you can remove it after the merge.
There was a problem hiding this comment.
The change in the .gitignore file should no longer exist. Thank you for pointing this out.
SvenKlaassen
approved these changes
Jun 13, 2023
removing testfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLR extended by the option to use external predictions
Description
The PLR model was extended by the possibility to calculate causal effects from externally generated predictions. This has been implemented along the lines of the IRM model.
As with the IRM model, the _nuisance_est method has been adapted so that it offers the possibility of passing external predictions in the fit method of the parent class.
In addition, the unit tests for comparing the values calculated manually and in the package have been extended. These now also compare the results between predictions generated with nuisance learner inside the package or predictions generated outside.