Update SA1111 to also check the parameter list in primary constructors #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3791 +/- ##
=======================================
Coverage 97.44% 97.45%
=======================================
Files 922 924 +2
Lines 109835 109842 +7
Branches 3315 3302 -13
=======================================
+ Hits 107027 107042 +15
- Misses 1834 1836 +2
+ Partials 974 964 -10 |
bjornhellander
force-pushed
the
feature/sa1111-primary-ctor-3785
branch
2 times, most recently
from
a460659 to
6cafeff
Compare
bjornhellander
changed the title
|
Ready for review |
|
Any comments here, @sharwell? |
bjornhellander
force-pushed
the
feature/sa1111-primary-ctor-3785
branch
4 times, most recently
from
ca78919 to
2269736
Compare
|
Any comments on this, @sharwell? |
bjornhellander
force-pushed
the
feature/sa1111-primary-ctor-3785
branch
from
2269736 to
5f00381
Compare
|
Rebased, fixed suggestions from previous pull requests and added handling of primary constructors in base lists. |
sharwell
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3785.
I also reduced code duplication in SA1111 by creating some helper methods.