Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1111 not triggered on record constructor #3785

Closed
bjornhellander opened this issue Jan 23, 2024 · 0 comments · Fixed by #3791
Closed

SA1111 not triggered on record constructor #3785

bjornhellander opened this issue Jan 23, 2024 · 0 comments · Fixed by #3791
Labels
bug c# 11 up for grabs

Comments

@bjornhellander
Copy link
Contributor

I expect the following code to trigger SA1111 (closing parenthesis must be on line of last parameter), but it does not:

public record MyType(int X, int y
    )
{
}

Tested with version 1.2.0-beta.556
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jan 30, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
a460659 
DotNetAnalyzers#3785
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jan 30, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
6cafeff 
DotNetAnalyzers#3785
@bjornhellander bjornhellander mentioned this issue Jan 30, 2024
Merged
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Feb 9, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
0cc4c87 
DotNetAnalyzers#3785
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Feb 10, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
6de2023 
DotNetAnalyzers#3785
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Feb 10, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
ca78919 
DotNetAnalyzers#3785
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Feb 10, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
2269736 
DotNetAnalyzers#3785
@sharwell sharwell changed the title SA1111 not triggered on primary constructor SA1111 not triggered on record constructor Mar 8, 2024
@sharwell sharwell added c# 11 and removed c# 12 labels Mar 8, 2024
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Mar 21, 2024
@bjornhellander
Update SA1111 to also check the parameter list in primary constructors
92e8a2c 
DotNetAnalyzers#3785
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Mar 21, 2024
@bjornhellander
Update SA1111 to also check the primary constructor argument list in …
5f00381 
…a base list

DotNetAnalyzers#3785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug c# 11 up for grabs
Projects
None yet
Milestone
No milestone
2 participants
@sharwell @bjornhellander