Code cleanup attempt #2 #2946
Merged
Code cleanup attempt #2 #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
==========================================
+ Coverage 97.37% 97.4% +0.03%
==========================================
Files 796 796
Lines 101593 101486 -107
Branches 3324 3318 -6
==========================================
- Hits 98925 98853 -72
+ Misses 1773 1739 -34
+ Partials 895 894 -1 |
sharwell
previously approved these changes
May 10, 2019
StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1121UnitTests.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #2933, based on review remarks there is a single commit for each type of change and no cancellationTokens have been removed in the process 😉