Code cleanup #2933
Closed
Code cleanup #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
+ Coverage 97.43% 97.47% +0.03%
==========================================
Files 778 778
Lines 100192 100088 -104
Branches 3266 3263 -3
==========================================
- Hits 97622 97556 -66
+ Misses 1702 1664 -38
Partials 868 868 |
sharwell
reviewed
Apr 28, 2019
| nameof(SA1503CodeFixProvider)), | ||
| diagnostic); | ||
| } | ||
| } | ||
|
|
||
| private static Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode root, StatementSyntax node, CancellationToken cancellationToken) |
There was a problem hiding this comment.
📝 I'm not a fan of removing the cancellation token parameters. See dotnet/roslyn#34441, and especially the design conclusion in dotnet/roslyn#34441 (comment).
|
I'll have a look tomorrow to see if I can break things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with VS2019 and noticed a lot of messages about code improvements 😄
There is room for more improvement, but #2599 is needed for that.