Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query persistable state #7

Closed
wants to merge 13 commits into from
Closed

query persistable state #7

wants to merge 13 commits into from

Conversation

Dosant
Copy link
Owner

@Dosant Dosant commented May 12, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

fkanout and others added 13 commits May 20, 2022 11:35
@fkanout
[Actionable Observability] Add execution log count in the last 24h in…
c136515 
… the Rule details page (elastic#132411)

* Add execution log count in the last 24h

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
@mgiota @kibanamachine
[Actionable Observability] Display action connector icon in o11y rule…
de90ea5 
… details page (elastic#132026)

* get iconClass from actionRegistry

* use suspendedComponentWithProps when iconClass is a react component and write some tests

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix xmatters svg icon

* apply design feedback

Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa @kibanamachine @Kuznietsov
[XY] Add addTimeMarker arg (elastic#131495)
f75b6fa 
* Add `addTimeMarker` arg

* Some fixes

* Update validation

* Fix snapshots

* Some fixes after merge

* Add unit tests

* Fix CI

* Update src/plugins/chart_expressions/expression_xy/public/helpers/data_layers.tsx

Co-authored-by: Yaroslav Kuznietsov <[email protected]>

* Fixed tests

* Fix checks

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yaroslav Kuznietsov <[email protected]>
@pgayvallet @kibanamachine
expose docLinks from ConfigDeprecationContext (elastic#132424)
569e10a 
* expose docLinks from ConfigDeprecationContext

* fix mock

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <[email protected]>
@VladLasitsa @kibanamachine
Remove injectedMetadata in vega (elastic#132521)
968f7a9 
* Remove injectedMetadata in vega

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <[email protected]>
@Dosant
[data.query] Add getState() api to retrieve whole QueryState (ela…
f88b140 
…stic#132035)
@academo @cnasikas
[Cases] Show deprecated icon in connectors with isDeprecated true (el…
473141f 
…astic#132237)

Co-authored-by: Christos Nasikas <[email protected]>
@criamico @kibanamachine
[Fleet] Changes to agent upgrade modal to allow for rolling upgrades (e…
aa4c389 
…lastic#132421)

* [Fleet] Changes to agent upgrade modal to allow for rolling upgrades

* Update the onSubmit logic and handle case with single agent

* Fix check

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Add option to upgrade immediately; minor fixes

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Add callout in modal for 400 errors

* Linter fixes

* Fix i18n error

* Address code review comments

Co-authored-by: kibanamachine <[email protected]>
@flash1293
add tooltip and change icon (elastic#132581)
57d783a
@walterra
[ML] Disable AIOps UI/APIs. (elastic#132589)
b3aee17 
This disables the UI and APIs for Explain log rate spikes in the ML plugin since it will not be part of 8.3. Once 8.3 has been branched off, we can reenable it in main. This also adds a check to the API integration tests to run the tests only when the hard coded feature flag is set to true.
@machadoum
Update user risk dashboard name (elastic#132441)
3b7c7e8
@alvarezmelissa87 @kibanamachine
[ML] Data Frame Analytics: replace custom types with estypes (elastic…
f0cb40a 
…#132443)

* replace common data_frame_analytics types from server with esclient types

* remove unused ts error ignore commments

* remove generic analyis type and move types to common dir

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* move types to commont folder

Co-authored-by: kibanamachine <[email protected]>
@Dosant
query pers state
8ec1b06
@Dosant Dosant force-pushed the d/2022-05-12-query-pers-state branch from e37d054 to 8ec1b06 Compare May 20, 2022 13:55
@Dosant Dosant closed this May 20, 2022
elasticmachine pushed a commit that referenced this pull request Sep 2, 2024
@crespocarlos @kibanamachine
[APM] Fix APM breadcrumbs on Serverless (elastic#191506)
60b8c05 
fixes
[#8](elastic/observability-accessibility#8)
fixes
[#7](elastic/observability-accessibility#7)
 
## Summary

Fixes APM breadcrumbs on serverless

| Serverless  |  Stateful  |
|---|---|
| <img width="700px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="800px" alt="image"
src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">|
| <img width="500px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/cb8a39e2-ca33-4cf9-a8ac-4c84566d092d">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/151a3a9c-c81e-4558-9d00-e695e3d1d79c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/2562e96f-d5e4-4aa4-a221-6721f8995883">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/8d877d11-8c3f-4ac5-8146-6a11125eae7c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/36e588cb-4c18-4d66-a2c6-f0e66392f708">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/14253196-06de-4343-811f-61aa31ea0d1e">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/0cdfc83f-6545-433f-8c14-5bbf2a581175">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/89a58e2b-2cef-4188-b2be-f359ba6890db">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/f15e767f-5b60-4485-ac71-7b6fd850ec50">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/a0f7bfae-bfda-4f49-b92a-e736d80fea4c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/680db8ab-58b8-454b-a0d7-6e1681dbe616">|


### How to test
#### Serverless
- Start a local ES serverless instance: `yarn es serverless
--projectType=oblt --ssl -k/--insecure`
- Start a local Kibana serverless instance: ` yarn start
--serverless=oblt --no-ssl`
- Run some synthtrace scenarios
- `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts
--live --target=https://elastic_serverless:[email protected]:9200
--kibana=http://elastic_serverless:[email protected]:5601`
- `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts
--live --target=https://elastic_serverless:[email protected]:9200
--kibana=http://elastic_serverless:[email protected]:5601`
- Navigate to Applications and click through the links

### Stateful
- Start a local ES and Kibana instance
- Run the some synthtrace scenarios:
  -  `node scripts/synthtrace mobile.ts --live`
  -  `node scripts/synthtrace service_map.ts --live`
- Navigate to Applications and click through the links

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.