Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add tooltip and change icon to "collapse by" feature #132581

Merged
merged 1 commit into from
May 20, 2022
Merged

[Lens] Add tooltip and change icon to "collapse by" feature #132581

merged 1 commit into from
May 20, 2022

Conversation

flash1293
Copy link
Contributor

The hidden icon used for collapsed columns is not ideal because it's already used for hidden columns in the table. This changes it to the fold icons which like a good fit conceptually. Also this adds a little explanatory text to the tooltip of the option.

Screenshot 2022-05-20 at 09 55 31

Screenshot 2022-05-20 at 09 55 37

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.3.0 labels May 20, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +724.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review May 20, 2022 09:34
@flash1293 flash1293 requested a review from a team as a code owner May 20, 2022 09:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally LGTM 👍

@flash1293 flash1293 merged commit 57d783a into elastic:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flash1293 @kibana-ci @elasticmachine @dej611