fix: Ensure tooltip doesn't override its anchor's ref #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
In #662 I made a mistake in the Tooltip component, which causes it to override the ref being passed to its anchor element. This breaks components that both require a tooltip, and another component that needs it as an anchor. For example, the scheduler in the new task detail's sidebar, which uses popper to display the scheduler menu. By losing the ref, the scheduler menu can't be positioned correctly near its trigger.
Unfortunately I couldn't test the build in-app as I'm running into issues with react-focus-lock once I pull in this branch through npm link (
ide run --link-reactist
), as Todoist is running a newer version and is able to dedupe the different copies when installing through npm normally. Even when updating the version here to match, I'm seeing weird behaviour once linked into the app. I'll have to test again once this is released.Test plan
Menu
Tooltip
PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
Patch