Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Reakit with Ariakit #662

Merged
merged 13 commits into from
May 25, 2022
Merged

refactor: Replace Reakit with Ariakit #662

merged 13 commits into from
May 25, 2022

Conversation

frankieyan
Copy link
Member

@frankieyan frankieyan commented May 19, 2022

Short description

This replaces Reakit with Ariakit, which powers our Menu, Tooltip, and Tabs components.

This includes a breaking change for Tabs, where if the selectedId prop is provided, it becomes a controlled component and will no longer switch tabs on its own. To retain the old behaviour, defaultSelectedId will need to be used instead.

Test plan

Each of the components should behave like the previously deployed version at https://doist.github.io/reactist/:

Menu

  • You can tab in and out of each menu item
  • With the "With sub-menu" example, a tooltip appears when you focus on the menu trigger
    • Pressing enter to select a menu item should place the focus back on the trigger, but not show the tooltip

Tooltip

  • Hovering or focusing on the box shows its tooltip

Tabs

  • Each demo's tabs show their corresponding content
  • Note that this is different from the deployed docs: In the canvas tab, selecting a value for selectedId prevents tabs from being changed when they're clicked on. Instead, in the actions tab, you'll find the onSelectedIdChange callback being logged

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)

Versioning

Major

@frankieyan frankieyan changed the base branch from main to frankie/react-17 May 19, 2022 22:09
@frankieyan frankieyan force-pushed the frankie/aria-kit branch 3 times, most recently from e76746e to d79cde0 Compare May 20, 2022 10:08
@frankieyan frankieyan requested review from a team and pedroalves0 and removed request for a team May 23, 2022 14:51
@frankieyan frankieyan self-assigned this May 23, 2022
@frankieyan frankieyan marked this pull request as ready for review May 23, 2022 14:52
@frankieyan frankieyan changed the title chore: Replace Reakit with Ariakit refactor: Replace Reakit with Ariakit May 23, 2022
Base automatically changed from frankie/react-17 to main May 25, 2022 07:27
@frankieyan frankieyan merged commit d0ea8c5 into main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants