-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace Reakit with Ariakit #662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieyan
force-pushed
the
frankie/aria-kit
branch
3 times, most recently
from
May 20, 2022 10:08
e76746e
to
d79cde0
Compare
12 tasks
frankieyan
force-pushed
the
frankie/react-17
branch
from
May 23, 2022 09:33
071f99a
to
57f26e5
Compare
frankieyan
force-pushed
the
frankie/aria-kit
branch
from
May 23, 2022 10:45
d79cde0
to
ae998bf
Compare
frankieyan
requested review from
a team and
pedroalves0
and removed request for
a team
May 23, 2022 14:51
frankieyan
changed the title
chore: Replace Reakit with Ariakit
refactor: Replace Reakit with Ariakit
May 23, 2022
pedroalves0
approved these changes
May 23, 2022
frankieyan
force-pushed
the
frankie/aria-kit
branch
from
May 25, 2022 07:35
74eb807
to
cda723c
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This replaces Reakit with Ariakit, which powers our
Menu
,Tooltip
, andTabs
components.This includes a breaking change for
Tabs
, where if theselectedId
prop is provided, it becomes a controlled component and will no longer switch tabs on its own. To retain the old behaviour,defaultSelectedId
will need to be used instead.Test plan
Each of the components should behave like the previously deployed version at https://doist.github.io/reactist/:
Menu
Tooltip
Tabs
selectedId
prevents tabs from being changed when they're clicked on. Instead, in the actions tab, you'll find theonSelectedIdChange
callback being loggedPR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refnpm run build-all
)Versioning
Major