Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hammer.js bug only happens if the value of eventType is 8. #4751

Closed
wants to merge 1 commit into from
Closed

The hammer.js bug only happens if the value of eventType is 8. #4751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions js/sideNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,19 +160,14 @@
$dragTarget.hammer({
prevent_default: false
}).bind('pan', function(e) {

if (e.gesture.pointerType == "touch") {
// Vertical scroll bugfix eventType Value === 8 is hammer.js bug
if (e.gesture.pointerType == "touch" && e.gesture.eventType !== 8) {

var direction = e.gesture.direction;
var x = e.gesture.center.x;
var y = e.gesture.center.y;
var velocityX = e.gesture.velocityX;

// Vertical scroll bugfix
if (x === 0 && y === 0) {
return;
}

// Disable Scrolling
var $body = $('body');
var $overlay = $('#sidenav-overlay');
Expand Down