The hammer.js bug only happens if the value of eventType is 8. #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think he generally means the removed line in the linked commit (and the error when a drag event occurs) even which has unexpected results and does not reliably filter the vertical scroll event. |
|
@tawon2137 Can you please provide some kind of demo/codepen, which reproduces the original problem? |
|
Https://github.com/Dogfalo/materialize/issues/4082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a developer studying the materialize css source. I noticed that during the creation of sidenav, Chrome experienced a drag error on newer browsers, and when the eventType value is 8, an odd value comes in. Share the source you have resolved as above.