SOV-3417: Fix proclamation type bugs #665

tiltom · 2023-10-31T10:24:47Z

Resolves:

changeset-bot · 2023-10-31T10:24:51Z

⚠️ No Changeset found

Latest commit: 72ea7c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2023-10-31T10:24:52Z

✅ Deploy Preview for sovryn-dapp ready!

Name	Link
🔨 Latest commit	`72ea7c0`
🔍 Latest deploy log	https://app.netlify.com/sites/sovryn-dapp/deploys/6540d5f17f97c9000870b747
😎 Deploy Preview	https://deploy-preview-665--sovryn-dapp.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* feat: initial Bitocracy content and stubs * fix: missing lazy load for Bitocracy page * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * SOV-3008: Proposal voting status (progress) (#565) * feat: add bar component with threshold option * SOV-3008: bitocracy voting result component * SOV-3226: Fix bitocracy alerts button (#610) * Fix bitocracy alerts button * Move EmailNotificationSettingsDialog to shared state * Create shiny-years-leave.md * SOV-3010: Individual Proposal page (#583) * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * feat: ProposalPage added * Create pink-buckets-rhyme.md * feat: update proposal page * feat: vote query * feat: resolve PR comments * feat: update cast vote in proposal * update proposal query * fix: mobile view * update gql * fix: proposal result issue * fix: show loading on proposal page * fix: cast vote error message * SOV-3009: voting actions (#597) * SOV-3009: voting actions * Create yellow-tips-sip.md * chore: fixes from comments * chore: update proposal status * chore: update proposal status * chore: update from comments * fix: proposal execution --------- Co-authored-by: Victor Creed <[email protected]> * fix: execution eta * SOV-3196: add voting tooltips to Voting proposals page (#603) * SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3211-3207: Bitocracy proposal issues (#614) * fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title * SOV-3195: add voting power section (#600) * SOV-3195: add voting power section * chore: add a tooltip for VP * chore: refactoring * Create giant-ducks-laugh.md * chore: updates from comments * fix: proposal status hook * chore: remove hrefExternal in view proposal button --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3225: Proposal row click (#625) * Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md * SOV-3011: Voting - Proposal CSV export (#627) * SOV-3011: add CSV export * chore: update text in proposal CSV file * SOV-3239: Support/Reject button in Cast your vote (#616) * feat: support reject proposal * Create olive-olives-obey.md * fix: refetch when voting is done * fix: casting issue * fix: hide when loading * fix: resolve PR comments * fix: casting vote issue * chore: increase gas limit --------- Co-authored-by: Victor Creed <[email protected]> --------- Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: tiltom <[email protected]> * SOV-3149: Proposal creation modal (#601) * feat: proposal creation modal * Create friendly-lobsters-retire.md * fix: resolve PR comments * feat: SOV-3236 proposal creation context and submission (#623) * SOV-3148: proposal creation form (#609) * feat: proposal creation form * Create bright-beers-swim.md * fix: resolve PR issues * fix: resolve PR issues * fix: PR issues * fix: remove unsused handler * fix: remove unused constants --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3237: Proposal creation - Proposal Overview (#637) * SOV-3237: Proposal creation - Proposal Overview * Create violet-dogs-kick.md * rebuild * chore: updates from comments --------- Co-authored-by: Victor Creed <[email protected]> * fix: merge conflicts * SOV-3315: create proposal form validation (#633) * fix: create proposal form validation * Create seven-boats-juggle.md * SOV-3238: add treasury data (#646) * SOV-3238: add treasury data * chore: update initial transfer state * chore: update remove button + max button * chore: update context + preview dialog * chore: update naming * chore: update preview component * chore: refactoring * chore: update naming * chore: move console.log to submit * chore: move contract addresses to const file * chore: refactoring ExecutableDetails component * Create great-tools-provide.md * chore: updates from comments * chore: update params * chore: update balances * chore: updates from comments * chore: update governor logic * chore: add required VP for creation propose * chore: added testnet addresses * chore: add governance selector * chore: temp hide balance validation * chore: fix from comments * SOV-3234: Proposal creation - Parameter Proposal Details (#658) * Adjust the initial step * UI - initial version * Add multiple parameters (without updating the context) * Save parameters step UI to the context * Delete functionality * Show real parameters * Parameter config entry * Add loan token logic beacon contracts * Add support for custom parameters * Small UI adjustments * chore: update params * chore: update params logic * chore: rm console * chore: add missing useEffect * SOV-3238: add treasury data (#646) * SOV-3238: add treasury data * chore: update initial transfer state * chore: update remove button + max button * chore: update context + preview dialog * chore: update naming * chore: update preview component * chore: refactoring * chore: update naming * chore: move console.log to submit * chore: move contract addresses to const file * chore: refactoring ExecutableDetails component * Create great-tools-provide.md * chore: updates from comments * chore: update params * chore: update balances * chore: updates from comments * chore: update governor logic * chore: add required VP for creation propose * chore: added testnet addresses * chore: add governance selector * chore: temp hide balance validation * chore: fix from comments * SOV-3234: parameters updates: - updated with main proposal branch - added validation - resolve conflicts * Create smart-drinks-smoke.md * chore: update governor address * chore: SOV-3321 update description * chore: update iTokens logic * Implement review changes * Remove checkPause from parameters list * Adjust custom contract and custom parameter sections --------- Co-authored-by: tiltom <[email protected]> * Fix proclamation type bugs (#665) * Fix custom contract/parameter data (#666) * Fix initial step labels * SOV-3449: Proposals bugs (#671) * Show new proposal button only if user has enough VP * Fix invalid parameter value * Disable create proposal button if a user has live proposal * Fix custom parameter function name saving * SOV-3458: Proposal bugs (#673) * SOV-3458 - validate amount * SOV-3456 - fix SOV contract address in proclamation proposals * SOV-3462 - fix styling of proposal status outcome * SOV-3463 - hide certaing executable details from non-treasury proposals * Fix new proposal button on mobile (#677) * Validate custom value (#679) * Fix mobile view (#683) * chore: update changeset messages --------- Co-authored-by: soulBit <[email protected]> Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: tiltom <[email protected]> Co-authored-by: Peiman <[email protected]> Co-authored-by: tiltom <[email protected]>

Fix proclamation type bugs

72ea7c0

tiltom added the bug Something isn't working label Oct 31, 2023

tiltom requested a review from creed-victor October 31, 2023 10:24

tiltom self-assigned this Oct 31, 2023

creed-victor approved these changes Oct 31, 2023

View reviewed changes

tiltom merged commit abad159 into feat/proposal-main-branch Oct 31, 2023
3 checks passed

tiltom deleted the fix/SOV-3417-proclamation-type-bugs branch October 31, 2023 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SOV-3417: Fix proclamation type bugs #665

SOV-3417: Fix proclamation type bugs #665

tiltom commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023

netlify bot commented Oct 31, 2023 •

edited

Loading

SOV-3417: Fix proclamation type bugs #665

SOV-3417: Fix proclamation type bugs #665

Conversation

tiltom commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

netlify bot commented Oct 31, 2023 • edited Loading

✅ Deploy Preview for sovryn-dapp ready!

netlify bot commented Oct 31, 2023 •

edited

Loading