SOV-3010: Individual Proposal page #583

Rickk137 · 2023-09-18T08:17:11Z

https://sovryn.atlassian.net/browse/SOV-3010
https://sovryn.atlassian.net/browse/SOV-2923

changeset-bot · 2023-09-18T08:17:16Z

🦋 Changeset detected

Latest commit: 241d56d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
frontend	Patch
@sovryn/contracts	Patch
@sovryn/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2023-09-18T08:17:16Z

✅ Deploy Preview for sovryn-dapp ready!

Name	Link
🔨 Latest commit	`241d56d`
🔍 Latest deploy log	https://app.netlify.com/sites/sovryn-dapp/deploys/651e914cfba0050008ba9926
😎 Deploy Preview	https://deploy-preview-583--sovryn-dapp.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.../frontend/src/app/5_pages/BitocracyPage/components/ProposalViewButton/ProposalViewButton.tsx

apps/frontend/src/app/5_pages/ProposalPage/hooks/useGetProposals.ts

apps/frontend/src/utils/graphql/rsk/operations/getProposals.graphql

apps/frontend/src/utils/graphql/rsk/operations/getProposal.graphql

apps/frontend/src/app/5_pages/ProposalPage/hooks/useGetProposalById.ts

apps/frontend/src/app/3_organisms/ProposalVotingResults/index.tsx

pietro-maximoff · 2023-09-19T17:21:56Z

apps/frontend/src/app/5_pages/ProposalPage/components/VoteTimer/VoteTimer.tsx

In the design, we have a tooltip with Vote start and Vote end data, but in the PRD we don't have any info about it, so I believe its better to check in which way we will go (with a tooltip or without) @soulBit

leave it according to PRD for now, we'll create a separate story for confirming how this should work and implementation

apps/frontend/src/app/5_pages/ProposalPage/components/VoteTimer/VoteTimer.tsx

apps/frontend/src/app/5_pages/ProposalPage/components/ExecutableDetails/ExecutableDetails.tsx

apps/frontend/src/app/5_pages/ProposalPage/ProposalPage.tsx

apps/frontend/src/app/3_organisms/ProposalVotingResults/index.tsx

apps/frontend/src/app/5_pages/ProposalPage/components/ProposalInfo/ProposalInfo.tsx

pietro-maximoff · 2023-09-19T20:22:02Z

apps/frontend/src/app/3_organisms/ProposalVotingResults/index.tsx

+        </Paragraph>
+        {currentBlock < endBlock ? (
+          <Paragraph size={ParagraphSize.small} className="italic">
+            {t(translations.proposalVotingResults.inProgress)}


when proposal in progress, the title should be In progress, Will succeed or In progress, Will be rejected

Rickk137 · 2023-09-20T10:05:19Z

@soulBit We are missing the Your voting power block which we have in design, but I can't find any info in PRD about it

* SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn

* SOV-3009: voting actions * Create yellow-tips-sip.md * chore: fixes from comments * chore: update proposal status * chore: update proposal status * chore: update from comments * fix: proposal execution --------- Co-authored-by: Victor Creed <[email protected]>

* SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]>

* fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title

* SOV-3195: add voting power section * chore: add a tooltip for VP * chore: refactoring * Create giant-ducks-laugh.md * chore: updates from comments * fix: proposal status hook * chore: remove hrefExternal in view proposal button --------- Co-authored-by: Victor Creed <[email protected]>

* Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md

* SOV-3011: add CSV export * chore: update text in proposal CSV file

* feat: support reject proposal * Create olive-olives-obey.md * fix: refetch when voting is done * fix: casting issue * fix: hide when loading * fix: resolve PR comments * fix: casting vote issue * chore: increase gas limit --------- Co-authored-by: Victor Creed <[email protected]>

* feat: initial Bitocracy content and stubs * feat: add Bitocracy menu option for SOV-2917 * chore: add changeset * fix: missing lazy load for Bitocracy page * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * SOV-3008: Proposal voting status (progress) (#565) * feat: add bar component with threshold option * SOV-3008: bitocracy voting result component * SOV-3226: Fix bitocracy alerts button (#610) * Fix bitocracy alerts button * Move EmailNotificationSettingsDialog to shared state * Create shiny-years-leave.md * SOV-3012: Bitocracy alerts (#580) * SOV-3012: Bitocracy alerts * Create fifty-baboons-fry.md * chore: cherry-pick from https://github.com/DistributedCollective/sovryn-dapp/pull/535/files * Fix invalid localization key * fix: duplicated deps --------- Co-authored-by: tiltom <[email protected]> Co-authored-by: Victor Creed <[email protected]> * SOV-3013: Voting - Next Steps modal (#564) * feat: Voting - Next Steps modal * Create two-ligers-relax.md * fix: resolve PR issue * fix: next step modal showing * fix: show next step dialog when tx dialog is closed * SOV-3010: Individual Proposal page (#583) * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * feat: ProposalPage added * Create pink-buckets-rhyme.md * feat: update proposal page * feat: vote query * feat: resolve PR comments * feat: update cast vote in proposal * update proposal query * fix: mobile view * update gql * fix: proposal result issue * fix: show loading on proposal page * fix: cast vote error message * SOV-3009: voting actions (#597) * SOV-3009: voting actions * Create yellow-tips-sip.md * chore: fixes from comments * chore: update proposal status * chore: update proposal status * chore: update from comments * fix: proposal execution --------- Co-authored-by: Victor Creed <[email protected]> * fix: execution eta * SOV-3196: add voting tooltips to Voting proposals page (#603) * SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3211-3207: Bitocracy proposal issues (#614) * fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title * SOV-3195: add voting power section (#600) * SOV-3195: add voting power section * chore: add a tooltip for VP * chore: refactoring * Create giant-ducks-laugh.md * chore: updates from comments * fix: proposal status hook * chore: remove hrefExternal in view proposal button --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3225: Proposal row click (#625) * Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md * SOV-3011: Voting - Proposal CSV export (#627) * SOV-3011: add CSV export * chore: update text in proposal CSV file * SOV-3239: Support/Reject button in Cast your vote (#616) * feat: support reject proposal * Create olive-olives-obey.md * fix: refetch when voting is done * fix: casting issue * fix: hide when loading * fix: resolve PR comments * fix: casting vote issue * chore: increase gas limit --------- Co-authored-by: Victor Creed <[email protected]> --------- Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: tiltom <[email protected]> * SOV-3319: Fix proposal type (#630) * Fix proposal type condition * Adjust exacutable details and proposal actions * Create brave-experts-cover.md * SOV-3312: Fix small bugs (#631) * Fix small bugs * Create small-fishes-work.md * Change layout of executable details * SOV-3288: Show the current state of voting (#632) * Show the current state of voting * Create thin-geckos-fail.md * Fix the copy * Fix review remarks * SOV-3327: Fix status labels (#636) * Fix status labels * Create moody-fans-attack.md * SOV-3334: Fix cast vote mobile (#639) * Fix cast section mobile view * Create happy-carrots-fold.md * Bump up proposal vote gas limit --------- Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: tiltom <[email protected]> Co-authored-by: tiltom <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: Peiman <[email protected]>

* SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * feat: ProposalPage added * Create pink-buckets-rhyme.md * feat: update proposal page * feat: vote query * feat: resolve PR comments * feat: update cast vote in proposal * update proposal query * fix: mobile view * update gql * fix: proposal result issue * fix: show loading on proposal page * fix: cast vote error message * SOV-3009: voting actions (#597) * SOV-3009: voting actions * Create yellow-tips-sip.md * chore: fixes from comments * chore: update proposal status * chore: update proposal status * chore: update from comments * fix: proposal execution --------- Co-authored-by: Victor Creed <[email protected]> * fix: execution eta * SOV-3196: add voting tooltips to Voting proposals page (#603) * SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3211-3207: Bitocracy proposal issues (#614) * fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title * SOV-3195: add voting power section (#600) * SOV-3195: add voting power section * chore: add a tooltip for VP * chore: refactoring * Create giant-ducks-laugh.md * chore: updates from comments * fix: proposal status hook * chore: remove hrefExternal in view proposal button --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3225: Proposal row click (#625) * Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md * SOV-3011: Voting - Proposal CSV export (#627) * SOV-3011: add CSV export * chore: update text in proposal CSV file * SOV-3239: Support/Reject button in Cast your vote (#616) * feat: support reject proposal * Create olive-olives-obey.md * fix: refetch when voting is done * fix: casting issue * fix: hide when loading * fix: resolve PR comments * fix: casting vote issue * chore: increase gas limit --------- Co-authored-by: Victor Creed <[email protected]> --------- Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: tiltom <[email protected]>

* feat: initial Bitocracy content and stubs * fix: missing lazy load for Bitocracy page * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * SOV-3008: Proposal voting status (progress) (#565) * feat: add bar component with threshold option * SOV-3008: bitocracy voting result component * SOV-3226: Fix bitocracy alerts button (#610) * Fix bitocracy alerts button * Move EmailNotificationSettingsDialog to shared state * Create shiny-years-leave.md * SOV-3010: Individual Proposal page (#583) * SOV-2922: voting proposals page (#552) * SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn * feat: ProposalPage added * Create pink-buckets-rhyme.md * feat: update proposal page * feat: vote query * feat: resolve PR comments * feat: update cast vote in proposal * update proposal query * fix: mobile view * update gql * fix: proposal result issue * fix: show loading on proposal page * fix: cast vote error message * SOV-3009: voting actions (#597) * SOV-3009: voting actions * Create yellow-tips-sip.md * chore: fixes from comments * chore: update proposal status * chore: update proposal status * chore: update from comments * fix: proposal execution --------- Co-authored-by: Victor Creed <[email protected]> * fix: execution eta * SOV-3196: add voting tooltips to Voting proposals page (#603) * SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3211-3207: Bitocracy proposal issues (#614) * fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title * SOV-3195: add voting power section (#600) * SOV-3195: add voting power section * chore: add a tooltip for VP * chore: refactoring * Create giant-ducks-laugh.md * chore: updates from comments * fix: proposal status hook * chore: remove hrefExternal in view proposal button --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3225: Proposal row click (#625) * Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md * SOV-3011: Voting - Proposal CSV export (#627) * SOV-3011: add CSV export * chore: update text in proposal CSV file * SOV-3239: Support/Reject button in Cast your vote (#616) * feat: support reject proposal * Create olive-olives-obey.md * fix: refetch when voting is done * fix: casting issue * fix: hide when loading * fix: resolve PR comments * fix: casting vote issue * chore: increase gas limit --------- Co-authored-by: Victor Creed <[email protected]> --------- Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: tiltom <[email protected]> * SOV-3149: Proposal creation modal (#601) * feat: proposal creation modal * Create friendly-lobsters-retire.md * fix: resolve PR comments * feat: SOV-3236 proposal creation context and submission (#623) * SOV-3148: proposal creation form (#609) * feat: proposal creation form * Create bright-beers-swim.md * fix: resolve PR issues * fix: resolve PR issues * fix: PR issues * fix: remove unsused handler * fix: remove unused constants --------- Co-authored-by: Victor Creed <[email protected]> * SOV-3237: Proposal creation - Proposal Overview (#637) * SOV-3237: Proposal creation - Proposal Overview * Create violet-dogs-kick.md * rebuild * chore: updates from comments --------- Co-authored-by: Victor Creed <[email protected]> * fix: merge conflicts * SOV-3315: create proposal form validation (#633) * fix: create proposal form validation * Create seven-boats-juggle.md * SOV-3238: add treasury data (#646) * SOV-3238: add treasury data * chore: update initial transfer state * chore: update remove button + max button * chore: update context + preview dialog * chore: update naming * chore: update preview component * chore: refactoring * chore: update naming * chore: move console.log to submit * chore: move contract addresses to const file * chore: refactoring ExecutableDetails component * Create great-tools-provide.md * chore: updates from comments * chore: update params * chore: update balances * chore: updates from comments * chore: update governor logic * chore: add required VP for creation propose * chore: added testnet addresses * chore: add governance selector * chore: temp hide balance validation * chore: fix from comments * SOV-3234: Proposal creation - Parameter Proposal Details (#658) * Adjust the initial step * UI - initial version * Add multiple parameters (without updating the context) * Save parameters step UI to the context * Delete functionality * Show real parameters * Parameter config entry * Add loan token logic beacon contracts * Add support for custom parameters * Small UI adjustments * chore: update params * chore: update params logic * chore: rm console * chore: add missing useEffect * SOV-3238: add treasury data (#646) * SOV-3238: add treasury data * chore: update initial transfer state * chore: update remove button + max button * chore: update context + preview dialog * chore: update naming * chore: update preview component * chore: refactoring * chore: update naming * chore: move console.log to submit * chore: move contract addresses to const file * chore: refactoring ExecutableDetails component * Create great-tools-provide.md * chore: updates from comments * chore: update params * chore: update balances * chore: updates from comments * chore: update governor logic * chore: add required VP for creation propose * chore: added testnet addresses * chore: add governance selector * chore: temp hide balance validation * chore: fix from comments * SOV-3234: parameters updates: - updated with main proposal branch - added validation - resolve conflicts * Create smart-drinks-smoke.md * chore: update governor address * chore: SOV-3321 update description * chore: update iTokens logic * Implement review changes * Remove checkPause from parameters list * Adjust custom contract and custom parameter sections --------- Co-authored-by: tiltom <[email protected]> * Fix proclamation type bugs (#665) * Fix custom contract/parameter data (#666) * Fix initial step labels * SOV-3449: Proposals bugs (#671) * Show new proposal button only if user has enough VP * Fix invalid parameter value * Disable create proposal button if a user has live proposal * Fix custom parameter function name saving * SOV-3458: Proposal bugs (#673) * SOV-3458 - validate amount * SOV-3456 - fix SOV contract address in proclamation proposals * SOV-3462 - fix styling of proposal status outcome * SOV-3463 - hide certaing executable details from non-treasury proposals * Fix new proposal button on mobile (#677) * Validate custom value (#679) * Fix mobile view (#683) * chore: update changeset messages --------- Co-authored-by: soulBit <[email protected]> Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: tiltom <[email protected]> Co-authored-by: Peiman <[email protected]> Co-authored-by: tiltom <[email protected]>

Rickk137 added the enhancement New feature or request label Sep 18, 2023

Rickk137 self-assigned this Sep 18, 2023

Rickk137 changed the title ~~Feat/sov 2923 proposal page~~ SOV-3010: Individual Proposal page Sep 18, 2023

creed-victor requested changes Sep 18, 2023

View reviewed changes

Rickk137 requested review from creed-victor and pietro-maximoff September 19, 2023 11:01

creed-victor requested changes Sep 19, 2023

View reviewed changes

apps/frontend/src/utils/graphql/rsk/operations/getProposal.graphql Outdated Show resolved Hide resolved

apps/frontend/src/app/5_pages/ProposalPage/hooks/useGetProposalById.ts Outdated Show resolved Hide resolved

pietro-maximoff requested changes Sep 19, 2023

View reviewed changes

creed-victor force-pushed the feat/bitocracy-main-branch branch from 3bfec50 to a1a9572 Compare September 20, 2023 07:58

Rickk137 force-pushed the feat/SOV-2923-proposal-page branch from c10721f to 05c57c5 Compare September 20, 2023 09:34

Rickk137 changed the base branch from feat/bitocracy-main-branch to feat/proposal-main-branch September 28, 2023 11:38

Rickk137 changed the base branch from feat/proposal-main-branch to feat/bitocracy-main-branch September 28, 2023 11:38

creed-victor force-pushed the feat/SOV-2923-proposal-page branch from 019dac7 to d699576 Compare October 3, 2023 12:18

creed-victor force-pushed the feat/bitocracy-main-branch branch from e919099 to ce82253 Compare October 3, 2023 12:22

creed-victor force-pushed the feat/SOV-2923-proposal-page branch from d699576 to 5419023 Compare October 3, 2023 12:42

creed-victor force-pushed the feat/bitocracy-main-branch branch from ce82253 to 98b1603 Compare October 4, 2023 09:32

pietro-maximoff and others added 10 commits October 4, 2023 12:33

SOV-2922: voting proposals page (#552)

638ac6d

* SOV-2922: voting proposals page * Create proud-rivers-give.md * chore: added changes from comments * chore: remove condition for past proposals * chore: added tooltip + added view button * chore: update proposal link + new proposal btn

feat: ProposalPage added

2d1a6cf

Create pink-buckets-rhyme.md

3c9a058

feat: update proposal page

416eec6

feat: vote query

108755f

feat: resolve PR comments

c477a61

feat: update cast vote in proposal

8e6ca80

update proposal query

e2d24e5

fix: mobile view

31b52fa

update gql

f1ba65e

Rickk137 and others added 8 commits October 4, 2023 12:33

fix: proposal result issue

de01573

fix: show loading on proposal page

dc37d76

fix: cast vote error message

d2d830a

fix: execution eta

1e1ae31

SOV-3196: add voting tooltips to Voting proposals page (#603)

72c7cc1

* SOV-3196: add voting tooltips to Voting proposals page * Create angry-mails-enjoy.md * chore: force deployment * chore: force deployment --------- Co-authored-by: Victor Creed <[email protected]>

SOV-3211-3207: Bitocracy proposal issues (#614)

156850a

* fix: bitocracy proposal title * Create many-fishes-hang.md * fix: define title limit * fix: update proposal title

creed-victor force-pushed the feat/SOV-2923-proposal-page branch from 5419023 to 8a16c9a Compare October 4, 2023 09:33

tiltom and others added 3 commits October 4, 2023 12:43

SOV-3225: Proposal row click (#625)

a7964a4

* Fix individual proposal opening * Fix review remarks * Change title tooltip trigger to hover * Create fresh-goats-begin.md

SOV-3011: Voting - Proposal CSV export (#627)

37426f6

* SOV-3011: add CSV export * chore: update text in proposal CSV file

tiltom merged commit 8865389 into feat/bitocracy-main-branch Oct 5, 2023

tiltom deleted the feat/SOV-2923-proposal-page branch October 5, 2023 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SOV-3010: Individual Proposal page #583

SOV-3010: Individual Proposal page #583

Rickk137 commented Sep 18, 2023

changeset-bot bot commented Sep 18, 2023 •

edited

Loading

netlify bot commented Sep 18, 2023 •

edited

Loading

pietro-maximoff Sep 19, 2023 •

edited

Loading

soulBit Sep 20, 2023

pietro-maximoff Sep 19, 2023

Rickk137 commented Sep 20, 2023

SOV-3010: Individual Proposal page #583

SOV-3010: Individual Proposal page #583

Conversation

Rickk137 commented Sep 18, 2023

changeset-bot bot commented Sep 18, 2023 • edited Loading

🦋 Changeset detected

netlify bot commented Sep 18, 2023 • edited Loading

✅ Deploy Preview for sovryn-dapp ready!

pietro-maximoff Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

soulBit Sep 20, 2023

Choose a reason for hiding this comment

pietro-maximoff Sep 19, 2023

Choose a reason for hiding this comment

Rickk137 commented Sep 20, 2023

changeset-bot bot commented Sep 18, 2023 •

edited

Loading

netlify bot commented Sep 18, 2023 •

edited

Loading

pietro-maximoff Sep 19, 2023 •

edited

Loading