Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight module system setup for shared code #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dfcowell
Copy link
Contributor

@dfcowell dfcowell commented Dec 5, 2021

This PR takes a very light touch to introducing yarn workspaces v1 and a shared module in the "common" directory.

Basically the same as my last PR (#17) except it doesn't completely rearrange the project directories.

This PR takes a very light touch to introducing yarn workspaces v1
and a shared module in the "common" directory.
@netlify
Copy link

netlify bot commented Dec 5, 2021

❌ Deploy Preview for stateofcss2021 failed.

🔨 Explore the source changes: 645945d

🔍 Inspect the deploy log: https://app.netlify.com/sites/stateofcss2021/deploys/61ac30c2f704ed0008462dc4

@dfcowell
Copy link
Contributor Author

dfcowell commented Dec 5, 2021

Just a couple of comments on this one.

  1. Workspaces hoists the yarn.lock file into the root directory and it contains all dependencies for all packages in the workspace, that's why the existing lockfiles were removed.
  2. I shuffled some small bits of shared config around into the root directory.

Copy link
Contributor

@b3nk3 b3nk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very neat approach. Clear and concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants