Repackage #17
Closed
Repackage #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for stateofcss2021 failed. 🔨 Explore the source changes: e0f9815 🔍 Inspect the deploy log: https://app.netlify.com/sites/stateofcss2021/deploys/61ab0bd8796d35000776b9fc |
dfcowell
commented
Dec 4, 2021
| @@ -11,6 +11,9 @@ import { initLocales } from './i18n' | |||
| import { initEntities } from './entities' | |||
| import { analyzeTwitterFollowings } from './rpcs' | |||
| import { clearCache } from './caching' | |||
| import { test } from '@stateofjs/common/src/index' | |||
There was a problem hiding this comment.
@SachaG here's an example of the common module import. It can be cleaned up to get rid of the src in the path, but it's more of an effort than I'm ready to invest in right now. If you want to just lift TS modules up into the root /packages/common directory that would be a valid compromise.
dfcowell
commented
Dec 4, 2021
| @@ -7,6 +7,9 @@ import colors from 'core/theme/colors' | |||
| import classNames from 'classnames' | |||
| import Hamburger from 'core/components/Hamburger' | |||
| import { useI18n } from 'core/i18n/i18nContext' | |||
| import { test } from '@stateofjs/common/src/index' | |||
There was a problem hiding this comment.
...and the front-end example.
This change adds support for sharing code between packages and composite TS compilation. A lot has changed in the project structure, but both front and backend can import code from @stateofjs/common (search for that in the project for a toy implementation of a shared module.) Still pending some documentation updates, but each individual package more or less works the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for sharing code between packages and composite TS compilation.
A lot has changed in the project structure, but both front and backend can import code from @stateofjs/common (search for that in the project for a toy implementation of a shared module.)
Still pending some documentation updates and unified build config, but each individual package more or less works the same.