-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable decoding of unpadded base64 strings #187
Enable decoding of unpadded base64 strings #187
Conversation
Turns out installing VS2022 side-by-side and a few new modules filled up my storage real good. Will check that box when I cleaned up. |
.../ViewModels/Tools/EncodersDecoders/Base64EncoderDecoder/Base64EncoderDecoderToolViewModel.cs
Outdated
Show resolved
Hide resolved
f15dae9
to
4612bfe
Compare
Actually, it seems like some unit tests don't pass anymore, according to the CI? 🤔 |
4612bfe
to
4ea7ad5
Compare
Oh damn, I'm glad I wrote that test lol. |
So it works fine locally, and also the failed test has nothing to do with this feature or my changes. Not sure how to fix that. |
4ea7ad5
to
cf604c0
Compare
Rebased onto main, let's see what happens I guess. |
Yup rebase worked, this one's ready now. |
Hello, |
Closes #178 Co-authored-by: Regenhardt Marlon <[email protected]>
Closes #178
Pull request type
Please check the type of change your PR introduces:
What is the current behaviour?
Pasting a base64 string without the final '=' can not be decoded.
Issue Number: #178
What is the new behaviour?
Pasting a base64 string without final '=' will add the final '=' to the data to be decoded. Input data in the form is not modified.
Other information
Quality check
Before creating this PR, have you: