Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen requirements for base64 decoding #178

Closed
kimipsen opened this issue Jan 21, 2022 · 3 comments · Fixed by #187
Closed

Loosen requirements for base64 decoding #178

kimipsen opened this issue Jan 21, 2022 · 3 comments · Fixed by #187
Labels
enhancement Idea of improvement of existing feature.
Milestone

Comments

@kimipsen
Copy link

Vote on this issue by adding a 👍 reaction.
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Is your feature request related to a problem? Please describe.
When pasting base64 encoded strings, often it won't decode these, unless I manually pad the ending with '='.

Describe the solution you'd like
It would improve usability if the tool automatically tried padding until the string became a valid/strict base64 string.

Describe alternatives you've considered
Consider showing a warning when failing to decode a string, as it currently is rather difficult to see whats happening.

@Regenhardt
Copy link
Contributor

I could imagine adding this real quick, seems like a good first issue?

Regenhardt pushed a commit to Regenhardt/DevToys that referenced this issue Jan 21, 2022
@AHollowedHunter
Copy link

I have been playing around with this myself, I've added automatic padding conditions but was also looking at implementing an InfoBar below the input box which can be used to provide feedback to the user if the input is invalid or has been automatically padded.

@veler veler added this to the v1.0.2.0 milestone Jan 22, 2022
@veler veler added the enhancement Idea of improvement of existing feature. label Jan 22, 2022
@btiteux btiteux removed this from the v1.0.2.0 milestone Jan 30, 2022
@i3anaan
Copy link

i3anaan commented Feb 16, 2022

Thought the decoding was simply broken, turns out it was missing the = padding. A warning would be much appreciated at the least.
For the record, this was the string I tried to decode: TWFsd2FyZQ

Regenhardt pushed a commit to Regenhardt/DevToys that referenced this issue Mar 21, 2022
Regenhardt pushed a commit to Regenhardt/DevToys that referenced this issue Mar 22, 2022
Regenhardt pushed a commit to Regenhardt/DevToys that referenced this issue Mar 23, 2022
veler pushed a commit that referenced this issue Mar 26, 2022
@veler veler added this to the v1.0.5.0 milestone Mar 27, 2022
veler pushed a commit that referenced this issue Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants