Add selector hasAttribute method (closes #1045) #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit b1c65f2 have failed. See details: |
|
@testcafe-build-bot \retest |
AlexanderMoskovkin
approved these changes
Apr 13, 2017
|
❌ Tests for the commit b1c65f2 have failed. See details: |
helen-dikareva
requested changes
Apr 14, 2017
| @@ -168,6 +168,16 @@ function addSnapshotPropertyShorthands (obj, getSelector, customDOMProperties, c | |||
| }); | |||
| }; | |||
|
|
|||
| obj.hasAttribute = attrName => { | |||
| var callsite = getCallsiteForMethod('getAttribute'); | |||
There was a problem hiding this comment.
var callsite = getCallsiteForMethod('getAttribute'); -> var callsite = getCallsiteForMethod('hasAttribute');
helen-dikareva
approved these changes
Apr 14, 2017
|
❌ Tests for the commit 2978d16 have failed. See details: |
|
❌ Tests for the commit 2978d16 have failed. See details: |
|
It looks like this never made it into the documentation. |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…#1403) * Add selector hasAttribute method (closes DevExpress#1045) * Fix callsite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @helen-dikareva @AlexanderMoskovkin