Add 'hasAttribute' method to DomNodeState

[miherlosev]

No description provided.

[AlexanderMoskovkin]

We have getAttribute method, do we really need hasAttribute?

await t.expect(element.hasAttribute('attr')).ok()

can be easily replaced with

await t.expect(element.getAttribute('attr')).ok()

/cc @miherlosev @DevExpress/testcafe

[miherlosev]

It will not work then attribute value equals ''.
I saw this case in animations (class name value toggles from empty to a some value)

<div class="fade"></div>
...
<div class=""></div>

[AlexanderMoskovkin]

why not

await t.expect(element.hasClass('fade')).ok()

?

[AlexanderMoskovkin]

but possible you are right because it doesn't work for an element like

<div contenteditable />

[miherlosev]

More

<input type="text" name="lname" disabled>

[AlexanderMoskovkin]

ok, I'm agree)

[inikulin]

Just why not to compare with void 0?

[miherlosev]

Yes, we can check a returned value.
But, it's more redable to use hasAttribute

Example

<input type="text" name="lname" test="" disabled>

.expect(input.getAttribute('wrong')).eql(null)
.expect(input.getAttribute('disabled')).eql('') //attribute without value returns ''
.expect(input.getAttribute('test')).eql('')

versus

.expect(input.hasAttribute('wrong')).notOk()
.expect(input.hasAttribute('disabled')).ok()
.expect(input.hasAttribute('test')).ok()

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.