Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): correct the 'EditingState' plugin docs #1226

Merged
merged 3 commits into from
Jul 6, 2018
Merged

fix(docs): correct the 'EditingState' plugin docs #1226

merged 3 commits into from
Jul 6, 2018

Conversation

SergeyAlexeev
Copy link
Contributor

Fixes #1223

@SergeyAlexeev SergeyAlexeev requested a review from kvet July 4, 2018 07:58
kvet
kvet reviewed Jul 4, 2018
View reviewed changes
Copy link
Contributor

@kvet kvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you hide getters and actions?

@SergeyAlexeev
Copy link
Contributor Author

I'm not sure they are useful. But I don't mind to return them back.

@kvet
Copy link
Contributor

kvet commented Jul 4, 2018

Let's return them

@SergeyAlexeev SergeyAlexeev merged commit b8735b6 into DevExpress:master Jul 6, 2018
@SergeyAlexeev SergeyAlexeev deleted the fix-onDeletedRowIdsChange branch July 6, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvet kvet kvet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeyAlexeev @kvet