[Bug] EditingState onDeletedRowIdsChange does not pass row ID as parameter

[thehig]

• I have searched this repository's issues and believe that this is not a duplicate.

I'm using ...

• React Grid
• React Chart
• Vue Grid

Example

https://codesandbox.io/s/q8o40kn474

Current Behaviour

Clicking an 'edit' button passes the row ID as a parameter to the onEditingRowIdsChange event. Clicking a 'delete' button passes nothing to the onDeletedRowIdsChange event, and calls onCommitChanges

Expected Behaviour

Clicking a 'delete' button passes the row ID as a parameter to the onDeletedRowIdsChange, and does not immediately call onCommitChanges when in controlled mode

---

Temporary Workaround

 <EditingState
      editingRowIds={editingRowIds}
      onEditingRowIdsChange={onEditingRowIdsChange}
      deletedRowIds={deletedRowIds}
      onDeletedRowIdsChange={() => {
        /* No-Op since this doesn't work properly https://github.com/DevExpress/devextreme-reactive/issues/1223 */
      }}
      rowChanges={rowChanges}
      onRowChangesChange={onRowChangesChange}
      addedRows={addedRows}
      onAddedRowsChange={onAddedRowsChange}
      onCommitChanges={changes =>
        // Don't immediately commit deletes, send them to the expected code path
        changes && changes.deleted
          ? onDeletedRowIdsChange(changes.deleted)
          : onCommitChanges(changes)
      }
    />

and in the Confirmation Dialog event handlers

     onCancelDelete={() => {
        // Set the deleting row IDs to empty
        onDeletedRowIdsChange([]);
      }}
      onConfirmDelete={() => {
        // Submit the deletion along the original commit path
        onCommitChanges({ deleted: deletedRowIds });
      }}

[SergeyAlexeev]

Hi,

Thank you for pointing out to this issue. The deletedRowIds property contains row IDs prepared for deletion and is required for 'Batch deleting'. This feature isn't fully implemented for now and it was premature to include descriptions of such properties.

Currently, a click on the 'Delete' button immediately commits rows to be deleted. Please refer to this demo to see how to delete rows in controlled mode.

[YamaRoo]

@SergeyAlexeev Would this be why deletedRowIds and onDeletedRowIds are not part of the Typescript definition for EditingState?

[SergeyAlexeev]

Yes, it is.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.