Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninvert EnableOwnership logic #623

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Uninvert EnableOwnership logic #623

merged 2 commits into from
Sep 13, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Fixes #582.

This was tested on Detsys's ephemeral Macs.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added the MacOS Darwin/MacOS label Sep 7, 2023
@Hoverbear Hoverbear self-assigned this Sep 7, 2023
@Hoverbear Hoverbear marked this pull request as ready for review September 7, 2023 17:40
@Hoverbear Hoverbear added this to the 0.11.1 milestone Sep 7, 2023
@Hoverbear Hoverbear requested a review from cole-h September 8, 2023 16:47
cole-h
cole-h approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@Hoverbear Hoverbear merged commit dd6edfb into main Sep 13, 2023
5 checks passed
@Hoverbear Hoverbear deleted the hoverbear/ds-1014-cant-enableownership-when-already-enabled branch September 13, 2023 16:38
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
MacOS Darwin/MacOS
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

macOS plan tries to enable ownership when it's already enabled
2 participants
@Hoverbear @cole-h